Message-ID: <585B3634.1050009@intel.com>
Date: Thu, 22 Dec 2016 10:11:00 +0800
From: Jike Song <jike.song@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: Alex Williamson <alex.williamson@redhat.com>
CC: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI
References: <20161221232315.6091.30612.stgit@gimli.home>
In-Reply-To: <20161221232315.6091.30612.stgit@gimli.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1471
Lines: 39

On 12/22/2016 07:27 AM, Alex Williamson wrote:
> Cleanup the namespace a bit by prefixing structures with mdev_ and
> also more concretely define the mdev interface.  Structs with comments
> defining which fields are private vs public tempts poor behavior,
> especially for an interface where we expect out of tree vendor drivers.

Personally I like this series :)

Side notes: 1) There is also Documentation to be updated; 2) your mail
address in Author field is @nuc.home?

--
Thanks,
Jike

> 
> ---
> 
> Alex Williamson (4):
>       vfio-mdev: Remove an unused structure element
>       vfio-mdev: de-polute the namespace, rename parent_device & parent_ops
>       vfio-mdev: Make mdev_parent private
>       vfio-mdev: Make mdev_device private and abstract interfaces
> 
> 
>  drivers/gpu/drm/i915/gvt/kvmgt.c |   22 +++++++------
>  drivers/vfio/mdev/mdev_core.c    |   64 ++++++++++++++++++++++++++++++--------
>  drivers/vfio/mdev/mdev_private.h |   28 +++++++++++++++--
>  drivers/vfio/mdev/mdev_sysfs.c   |    8 ++---
>  drivers/vfio/mdev/vfio_mdev.c    |   12 ++++---
>  include/linux/mdev.h             |   54 +++++++-------------------------
>  samples/vfio-mdev/mtty.c         |   28 +++++++++--------
>  7 files changed, 123 insertions(+), 93 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>