Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934154AbcLVGhA (ORCPT ); Thu, 22 Dec 2016 01:37:00 -0500 Received: from verein.lst.de ([213.95.11.211]:53694 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765783AbcLVGg6 (ORCPT ); Thu, 22 Dec 2016 01:36:58 -0500 Date: Thu, 22 Dec 2016 07:36:56 +0100 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , Linus Torvalds , Chris Leech , Linux Kernel Mailing List , Lee Duncan , open-iscsi@googlegroups.com, Linux SCSI List , linux-block@vger.kernel.org Subject: Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0 Message-ID: <20161222063656.GA31973@lst.de> References: <20161214222411.GH4326@dastard> <20161214222953.GI4326@dastard> <20161216185906.t2wmrr6wqjdsrduw@straylight.hirudinean.org> <20161221221638.GD4758@dastard> <20161222061827.GA31630@lst.de> <20161222063046.GH4758@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161222063046.GH4758@dastard> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 520 Lines: 10 On Thu, Dec 22, 2016 at 05:30:46PM +1100, Dave Chinner wrote: > > For "normal" bios the for_each_segment loop iterates over bi_vcnt, > > so it will be ignored anyway. That being said both I and the lists > > got CCed halfway through the thread and I haven't seen the original > > report, so I'm not really sure what's going on here anyway. > > http://www.gossamer-threads.com/lists/linux/kernel/2587485 This doesn't look like the discard changes, but if Chris wants to test without them f9d03f96b988 reverts cleanly.