Date: Thu, 15 May 2003 17:14:57 -0700 (PDT)
Message-Id: <20030515.171457.02279102.davem@redhat.com>
To: chas@locutus.cmf.nrl.navy.mil
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] add reference counting to atm_dev 
From: "David S. Miller" <davem@redhat.com>
In-Reply-To: <200305152020.h4FKKfGi014696@locutus.cmf.nrl.navy.mil>
References: <20030515.131021.104054490.davem@redhat.com>
	<200305152020.h4FKKfGi014696@locutus.cmf.nrl.navy.mil>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 892
Lines: 24

   From: chas williams <chas@locutus.cmf.nrl.navy.mil>
   Date: Thu, 15 May 2003 16:20:41 -0400

   i suspect atm doesnt use rtnl because its register/unregister
   function dont use the underlying netdevice layer (when perhaps it
   should).

There is no correlation between whether you use netdevice or not
and whether network configuration changes should be synchronized
using the RTNL semaphore :-)

   thanks for the pointer.
   
No problem.

   here is the the atm_dev locking patch with the __module_get change:
   
Ok, I'll apply this.  But long term we really need to clean out
the cobwebs here, use RTNL, do solid module refcounting etc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/