Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763630AbcLVK0m (ORCPT ); Thu, 22 Dec 2016 05:26:42 -0500 Received: from mail-wj0-f194.google.com ([209.85.210.194]:33554 "EHLO mail-wj0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800AbcLVK0k (ORCPT ); Thu, 22 Dec 2016 05:26:40 -0500 From: Nicolai Stange To: Mika =?utf-8?Q?Penttil=C3=A4?= Cc: Nicolai Stange , Matt Fleming , Ard Biesheuvel , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , , , Subject: Re: [PATCH 2/2] efi: efi_mem_reserve(): don't reserve through memblock after mm_init() References: <20161221182846.2968-1-nicstange@gmail.com> <20161221182846.2968-2-nicstange@gmail.com> Date: Thu, 22 Dec 2016 11:26:36 +0100 In-Reply-To: ("Mika \=\?utf-8\?Q\?Penttil\=C3\=A4\=22's\?\= message of "Wed, 21 Dec 2016 20:45:13 +0200") Message-ID: <87zijoz2cj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBMAQkta012928 Content-Length: 662 Lines: 21 Mika Penttilä writes: > On 21.12.2016 20:28, Nicolai Stange wrote: >> /** >> * efi_mem_reserve - Reserve an EFI memory region >> @@ -419,7 +422,7 @@ void __init __weak efi_arch_mem_reserve(phys_addr_t addr, u64 size) {} >> */ >> void __init efi_mem_reserve(phys_addr_t addr, u64 size) >> { >> - if (!memblock_is_region_reserved(addr, size)) >> + if (slab_is_available() && !memblock_is_region_reserved(addr, size)) >> memblock_reserve(addr, size); > Maybe !slab_is_available() ? You're right, thanks for catching this! Fixed in v2 at http://lkml.kernel.org/r/20161222102340.2689-2-nicstange@gmail.com Thanks, Nicolai