Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965566AbcLVOfP (ORCPT ); Thu, 22 Dec 2016 09:35:15 -0500 Received: from mga01.intel.com ([192.55.52.88]:45465 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933162AbcLVOfN (ORCPT ); Thu, 22 Dec 2016 09:35:13 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,388,1477983600"; d="scan'208";a="1085521521" Message-ID: <1482417309.9552.128.camel@linux.intel.com> Subject: Re: [v1] i2c: busses: i2c-designware-pcidrv:- Handle return NULL error from pcim_iomap_table From: Andy Shevchenko To: Arvind Yadav , jarkko.nikula@linux.intel.com, wsa@the-dreams.de Cc: mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 22 Dec 2016 16:35:09 +0200 In-Reply-To: <1482406759-13094-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1482406759-13094-1-git-send-email-arvind.yadav.cs@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 31 On Thu, 2016-12-22 at 17:09 +0530, Arvind Yadav wrote: > Here, If pcim_iomap_table will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > This error check will avoid NULL pointer dereference. > > Signed-off-by: Arvind Yadav > --- >  drivers/i2c/busses/i2c-designware-pcidrv.c |    4 ++++ >  1 file changed, 4 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c > b/drivers/i2c/busses/i2c-designware-pcidrv.c > index d6423cf..6a1907d 100644 > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c > @@ -235,6 +235,10 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev, >   dev->controller = controller; >   dev->get_clk_rate_khz = i2c_dw_get_clk_rate_khz; >   dev->base = pcim_iomap_table(pdev)[0]; > + if (!dev->base) { > + dev_err(&pdev->dev, "I/O map table allocation > failed\n"); > + return -ENOMEM; > + } NAK. -- Andy Shevchenko Intel Finland Oy