Subject: Re: Build warning on 32-bit PPC - bisected to commit 989cea5c14be
To: Nicholas Piggin <npiggin@gmail.com>
References: <53d94073-6e7e-af83-a29a-e811ab5fd802@lwfinger.net>
 <20161222120224.36202396@roar.ozlabs.ibm.com>
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
        Michal Marek <mmarek@suse.com>, LKML <linux-kernel@vger.kernel.org>,
        linuxppc-dev <linuxppc-dev@ozlabs.org>
From: Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <975651aa-16b7-7e85-67d0-325e590ff0ed@lwfinger.net>
Date: Thu, 22 Dec 2016 08:53:07 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20161222120224.36202396@roar.ozlabs.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 715
Lines: 22

On 12/21/2016 08:02 PM, Nicholas Piggin wrote:
> Hi Larry,
>
> This is strange you've bisected it there, I can't see how that patch would
> trigger it. That said, powerpc has had a few small build system glitches.
>
> It looks like this warning could be fixed by changing #elif CONFIG_FSL_BOOKE
> to #elif defined (CONFIG_FSL_BOOKE). Want to send a patch (if it works)?

Nick,

I agree that the "bad" commit does not look likely to be the problem, but I 
verified it by checking out the previous commit, which does not show the 
problem. I'm quite sure that PowerPC has a lot of quirks and glitches beyond 
those caused by the Apple hardware.

I have tested the change and I will submit the patch.

Thanks,

Larry