Subject: Re: [PATCH 2/3] xen: return xenstore command failures via response
 instead of rc
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20161222071948.23862-1-jgross@suse.com>
 <20161222071948.23862-3-jgross@suse.com>
 <9dc05fb2-cb84-d8e7-848b-37fb9c86b782@oracle.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <cdfb649a-1fdd-ef0b-aeb1-fd12281f014f@suse.com>
Date: Thu, 22 Dec 2016 16:55:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <9dc05fb2-cb84-d8e7-848b-37fb9c86b782@oracle.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 585
Lines: 16

On 22/12/16 16:49, Boris Ostrovsky wrote:
> On 12/22/2016 02:19 AM, Juergen Gross wrote:
>> When the xenbus driver does some special handling for a Xenstore
>> command any error condition related to the command should be returned
>> via an error response instead of letting the related write operation
>> fail. Otherwise the user land handler might take wrong decisions
>> assuming the connection to Xenstore is broken.
> 
> Do we expect the user to always read the reply if no error code was
> returned?

Absolutely, yes. This is how error reporting of Xenstore is
working.


Juergen