Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935846AbcLVQBn (ORCPT ); Thu, 22 Dec 2016 11:01:43 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:40125 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756387AbcLVQBm (ORCPT ); Thu, 22 Dec 2016 11:01:42 -0500 Subject: Re: [PATCH 2/3] xen: return xenstore command failures via response instead of rc To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20161222071948.23862-1-jgross@suse.com> <20161222071948.23862-3-jgross@suse.com> <9dc05fb2-cb84-d8e7-848b-37fb9c86b782@oracle.com> From: Boris Ostrovsky Message-ID: <37204bbe-f08e-1a46-e56e-7d8eec67414f@oracle.com> Date: Thu, 22 Dec 2016 11:00:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 17 On 12/22/2016 10:55 AM, Juergen Gross wrote: > On 22/12/16 16:49, Boris Ostrovsky wrote: >> On 12/22/2016 02:19 AM, Juergen Gross wrote: >>> When the xenbus driver does some special handling for a Xenstore >>> command any error condition related to the command should be returned >>> via an error response instead of letting the related write operation >>> fail. Otherwise the user land handler might take wrong decisions >>> assuming the connection to Xenstore is broken. >> Do we expect the user to always read the reply if no error code was >> returned? > Absolutely, yes. This is how error reporting of Xenstore is > working. Oh, right --- I was thinking about the string that you are passing back but not the message type (XS_ERROR). Reviewed-by: Boris Ostrovsky