Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966427AbcLVQix (ORCPT ); Thu, 22 Dec 2016 11:38:53 -0500 Received: from exsmtp02.microchip.com ([198.175.253.38]:34658 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966361AbcLVQiP (ORCPT ); Thu, 22 Dec 2016 11:38:15 -0500 From: Cyrille Pitchen To: , , CC: , , , Cyrille Pitchen Subject: [PATCH v2 10/12] crypto: atmel-aes: fix atmel_aes_handle_queue() Date: Thu, 22 Dec 2016 17:37:59 +0100 Message-ID: <82a83bf030641719067b649d67817dd99e445059.1482424395.git.cyrille.pitchen@atmel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-Brightmail-Tracker: H4sIAAAAAAAAC+NgFupiVWLjYuHi8mHRLWOMiTDY82TWFkaLwwunMFo8eN/JYjFt+jtmi3uftjFadExZxeTAGsAQxZqZl5RfkcCa0T6hkb3gCmfF+i0LmRsY/7J3MXJxCAmsY5RYPOcOaxcjJwebgKHE2wdHwWwRgUCJhS2vGEGKmAWmM0o8WP2OHSQhLOApsXJ2K5jNIqAq8eTcImYQm1cgXmLRqyeMILaEgJzEzXOdYHFOAVuJ9XPvAQ3lANpmI3HwrRBEuaDEyZlPWEBsZgEJiYMvXoCVCwmoAe1dwQwxJlDiyf1NULaTxKyfm1kgbDuJw9MvskPY9hKX9l1igam59PEFE4StLbH91T5WCFtHYtvBfqgaW4k9MyZC1bhLPHi0HMr2lZj1sAGqJkridvMu9gmMErOQnDoLyakLGJlWMUo7e/jpBofpukY4exgY6eUmZxTo5iZm5ukl5+duYoTEk9oOxpk9/ocYJTmYlER5t046Hy7El5SfUpmRWJwRX1Sak1p8iFGCg0dJhHfjcqAcb3FBYm5xZjpMSoaDQ0mCNwIkJViUmp5akZaZU5JaBJE+xSgpJc4bDZIUAOnLKM2Dy11iFJUS5o1aCpTjKUgtys0sgYjfYhTmeMgkxJKXn5cqBXQiAxBoML5iFOdgVBLm3Q8yiyczrwTuhFdA1zEBXbdu92mQ60oSEVJSDYxaMfrpnxdcNmR1q7NTubcntP/0+h3btMNdQryOP5zq5awfGHgu5Y3tsfULf/18XbsqLiN4ZrL/bp6kSdx3d60s+3fnjcDrkrLbMm+8st9KOXyI+D8/btOKa3yurbEfZzS3hO+47yNxTyFk7g39o0o9GldsdmY5bzNJUEjfmm8o+y7ZieVWurQSS3FGoqEWc1FxIgCA9TNZHQMAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 38 This patch fixes the value returned by atmel_aes_handle_queue(), which could have been wrong previously when the crypto request was started synchronously but became asynchronous during the ctx->start() call. Signed-off-by: Cyrille Pitchen --- drivers/crypto/atmel-aes.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index 0e3d0d655b96..9fd2f63b8bc0 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -879,6 +879,7 @@ static int atmel_aes_handle_queue(struct atmel_aes_dev *dd, struct crypto_async_request *areq, *backlog; struct atmel_aes_base_ctx *ctx; unsigned long flags; + bool start_async; int err, ret = 0; spin_lock_irqsave(&dd->lock, flags); @@ -904,10 +905,12 @@ static int atmel_aes_handle_queue(struct atmel_aes_dev *dd, dd->areq = areq; dd->ctx = ctx; - dd->is_async = (areq != new_areq); + start_async = (areq != new_areq); + dd->is_async = start_async; + /* WARNING: ctx->start() MAY change dd->is_async. */ err = ctx->start(dd); - return (dd->is_async) ? ret : err; + return (start_async) ? ret : err; } -- 2.7.4