Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966105AbcLVWdk (ORCPT ); Thu, 22 Dec 2016 17:33:40 -0500 Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:31018 "EHLO ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760301AbcLVWdj (ORCPT ); Thu, 22 Dec 2016 17:33:39 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DdIgDOU1xYIOyiLHleGgEBAQECAQEBAQgBAQEBgzUBAQEBAR+BZoJ+g3mHTJQ3AQEBAQEHgRyMOIQPhE6CCYYcAgIBAQKBa0ETAQIBAQEBAQEBBgEBAQEBATlFQhKEFQEFOhwjEAgDGAklDwUlAwcaE4hgDK0riwABAQEBBgEBAQEkIIVjhSeBPwGIawWaeJEtkF9JjV2EDyECM4EIFg2EIyeBWSo0giyGPQEBAQ Date: Fri, 23 Dec 2016 09:33:36 +1100 From: Dave Chinner To: Linus Torvalds Cc: Jens Axboe , Thomas Gleixner , Ingo Molnar , Peter Anvin , Linux Kernel Mailing List , the arch/x86 maintainers Subject: Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0 Message-ID: <20161222223336.GM4758@dastard> References: <20161221221638.GD4758@dastard> <20161222001303.nvrtm22szn3hgxar@straylight.hirudinean.org> <20161222051322.GF4758@dastard> <20161222062858.GG4758@dastard> <20161222204240.GJ4758@dastard> <20161222210607.GK4758@dastard> <20161222221500.GL4758@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161222221500.GL4758@dastard> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1813 Lines: 44 On Fri, Dec 23, 2016 at 09:15:00AM +1100, Dave Chinner wrote: > On Thu, Dec 22, 2016 at 01:10:19PM -0800, Linus Torvalds wrote: > > Ok, so the numa issue was a red herring. With that fixed: > > > > On Thu, Dec 22, 2016 at 1:06 PM, Dave Chinner wrote: > > > > > > Better, but still bad. average files/s is not up to 200k files/s, > > > so still a good 10-15% off where it should be. xfs_repair is back > > > down to 10-15% off where it should be, too. bulkstat still fires off > > > a bad page reference count warning, iscsi still panics immediately. > > > > Do you have CONFIG_BLK_WBT enabled, perhaps? > > Ok, yes, that's enabled. Let me go turn it off and see what happens. Numbers are still all over the place. FSUse% Count Size Files/sec App Overhead ..... 0 28800000 0 228175.5 21928812 0 30400000 0 167880.5 39628229 0 32000000 0 124289.5 41420925 0 33600000 0 150577.9 35382318 0 35200000 0 216535.4 16072628 0 36800000 0 233414.4 11846654 0 38400000 0 213812.0 13356633 0 40000000 0 175905.7 53012015 0 41600000 0 157028.7 34700794 0 43200000 0 138829.1 50282461 And the average is now back down to 185k files/s. repair runtime is unchanged and still 10-15% off... I've got to run away for a few hours right now, but I'll retest the 4.9 + xfs for-next branch when I get back to see if the problem is my curent config or whether there really is a perf problem lurking somewhere.... Cheers, Dave. -- Dave Chinner david@fromorbit.com