Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966861AbcLVW55 (ORCPT ); Thu, 22 Dec 2016 17:57:57 -0500 Received: from p3plsmtps2ded01.prod.phx3.secureserver.net ([208.109.80.58]:58530 "EHLO p3plsmtps2ded01.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966614AbcLVW5z (ORCPT ); Thu, 22 Dec 2016 17:57:55 -0500 x-originating-ip: 72.167.245.219 From: kys@exchange.microsoft.com To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com Cc: "K. Y. Srinivasan" , Subject: [PATCH 2/4] Drivers: hv: util: kvp: Fix a rescind processing issue Date: Thu, 22 Dec 2016 16:54:01 -0800 Message-Id: <1482454443-10306-2-git-send-email-kys@exchange.microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1482454443-10306-1-git-send-email-kys@exchange.microsoft.com> References: <1482454418-10265-1-git-send-email-kys@exchange.microsoft.com> <1482454443-10306-1-git-send-email-kys@exchange.microsoft.com> Reply-To: kys@microsoft.com X-CMAE-Envelope: MS4wfHBzCVUctNq+ZYMr9wbLjmX1gpPzRd5JXyIVIRTItV72SmxDUgDeqXq4BWOrGtF9FnXTNdI5BFSwUEN8EpICZjGyZZXLYA8h4ikt237D8mTwvicTlD6D rCOI8yVVAwTTul6DMBySfuYHHQw3ZT3p9AkWBDFDa+YgSY2hBiGTQvOsTv4afqNWuQM7oO3LVwqUXhbkN75C7HHt0aecJLh6mPOOAgFoT4kHDI4e9HNZWfc9 gcrdqi2TeeaWakthjCTYfZQ6+K31H0E6W0fmQ3FKyRm9QgE7FFRSxtxGDTjmnDX3g77xcUWFAPjNmxQ8oGXkeoPu6Ag+ywdc5kD7ztJ3E+4nx0geMBN9cVIe Kl1HZpMzNCtOBRYVEWg7xKhKFEWq21av5oxN+k5Xgr8j3CNn2BtAMbeVIxnYLVeXBuZlMype5fRMKbvIwz95nmwLeEqdmudX7cGFDPLPgfIP894V1sHyiXDq V1JYPcFp6BWquPXxhhe3IAcMrAK1arhy4AV6ZQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 49 From: K. Y. Srinivasan KVP may use a char device to support the communication between the user level daemon and the driver. When the KVP channel is rescinded we need to make sure that the char device is fully cleaned up before we can process a new KVP offer from the host. Implement this logic. Signed-off-by: K. Y. Srinivasan Cc: --- drivers/hv/hv_kvp.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c index 5e1fdc8..3abfc59 100644 --- a/drivers/hv/hv_kvp.c +++ b/drivers/hv/hv_kvp.c @@ -88,6 +88,7 @@ static const char kvp_devname[] = "vmbus/hv_kvp"; static u8 *recv_buffer; static struct hvutil_transport *hvt; +static struct completion release_event; /* * Register the kernel component with the user-level daemon. * As part of this registration, pass the LIC version number. @@ -716,6 +717,7 @@ static void kvp_on_reset(void) if (cancel_delayed_work_sync(&kvp_timeout_work)) kvp_respond_to_host(NULL, HV_E_FAIL); kvp_transaction.state = HVUTIL_DEVICE_INIT; + complete(&release_event); } int @@ -724,6 +726,7 @@ static void kvp_on_reset(void) recv_buffer = srv->recv_buffer; kvp_transaction.recv_channel = srv->channel; + init_completion(&release_event); /* * When this driver loads, the user level daemon that * processes the host requests may not yet be running. @@ -747,4 +750,5 @@ void hv_kvp_deinit(void) cancel_delayed_work_sync(&kvp_timeout_work); cancel_work_sync(&kvp_sendkey_work); hvutil_transport_destroy(hvt); + wait_for_completion(&release_event); } -- 1.7.4.1