Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758247AbcLWFiu (ORCPT ); Fri, 23 Dec 2016 00:38:50 -0500 Received: from nbd.name ([46.4.11.11]:49253 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbcLWFit (ORCPT ); Fri, 23 Dec 2016 00:38:49 -0500 Subject: Re: [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc To: Colin King , Ralf Baechle , linux-mips@linux-mips.org References: <20161222235258.5525-1-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org From: John Crispin Message-ID: <7ca20b25-60d8-b439-0e30-671549d641bb@phrozen.org> Date: Fri, 23 Dec 2016 06:38:45 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161222235258.5525-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 35 On 23/12/2016 00:52, Colin King wrote: > From: Colin Ian King > > ralink_soc sould be assigned to RT3883_SOC, replace incorrect > comparision with assignment. > > Signed-off-by: Colin Ian King Acked-by: John Crispin i thought i had sent this fix upstream ages ago. luckily this bug never caused any error as none of the code checking ralink_soc checks for rt3883. its used for the rt3x5x family. John > --- > arch/mips/ralink/rt3883.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c > index 141c597..f869052 100644 > --- a/arch/mips/ralink/rt3883.c > +++ b/arch/mips/ralink/rt3883.c > @@ -157,5 +157,5 @@ void prom_soc_init(struct ralink_soc_info *soc_info) > > rt2880_pinmux_data = rt3883_pinmux_data; > > - ralink_soc == RT3883_SOC; > + ralink_soc = RT3883_SOC; > } > his