Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965508AbcLWKAK (ORCPT ); Fri, 23 Dec 2016 05:00:10 -0500 Received: from www.osadl.org ([62.245.132.105]:33477 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbcLWKAH (ORCPT ); Fri, 23 Dec 2016 05:00:07 -0500 From: Nicholas Mc Guire To: Thomas Gleixner Cc: Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH RFC] x86, boot: add missing declaration of string functions Date: Fri, 23 Dec 2016 11:01:36 +0100 Message-Id: <1482487296-5064-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2614 Lines: 62 Add the missing declarations of basic string functions to string.h to allow a clean build. Fixes: commit 5be865661516 ("String-handling functions for the new x86 setup code.") Signed-off-by: Nicholas Mc Guire --- sparse issues a set of warnings about missing declarations: arch/x86/purgatory/../boot/string.c:18:5: warning: symbol 'memcmp' was not declared. Should it be static? arch/x86/purgatory/../boot/string.c:26:5: warning: symbol 'strcmp' was not declared. Should it be static? arch/x86/purgatory/../boot/string.c:42:5: warning: symbol 'strncmp' was not declared. Should it be static? arch/x86/purgatory/../boot/string.c:58:8: warning: symbol 'strnlen' was not declared. Should it be static? arch/x86/purgatory/../boot/string.c:69:14: warning: symbol 'atou' was not declared. Should it be static? arch/x86/purgatory/../boot/string.c:99:20: warning: symbol 'simple_strtoull' was not declared. Should it be static? arch/x86/purgatory/../boot/string.c:128:8: warning: symbol 'strlen' was not declared. Should it be static? arch/x86/purgatory/../boot/string.c:142:6: warning: symbol 'strstr' was not declared. Should it be static? This patch has one checkpatch warning about the use of simple_strtoul which is obsolete. As this is an independent implementation it is not clear if the changes made in simple_strtoul -> _kstrtoull might also need to be applied here ? Patch was compile tested with: x86_64_defconfig Patch is against 4.9.0 (localversion-next is next-20161223) arch/x86/boot/string.c | 1 + arch/x86/boot/string.h | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c index cc3bd58..9e240fc 100644 --- a/arch/x86/boot/string.c +++ b/arch/x86/boot/string.c @@ -14,6 +14,7 @@ #include #include "ctype.h" +#include "string.h" int memcmp(const void *s1, const void *s2, size_t len) { diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h index 725e820..f6ee139 100644 --- a/arch/x86/boot/string.h +++ b/arch/x86/boot/string.h @@ -18,4 +18,13 @@ int memcmp(const void *s1, const void *s2, size_t len); #define memset(d,c,l) __builtin_memset(d,c,l) #define memcmp __builtin_memcmp +int strcmp(const char *str1, const char *str2); +int strncmp(const char *cs, const char *ct, size_t count); +size_t strlen(const char *s); +char *strstr(const char *s1, const char *s2); +size_t strnlen(const char *s, size_t maxlen); +unsigned int atou(const char *s); +unsigned long long simple_strtoull(const char *cp, + char **endp, unsigned int base); + #endif /* BOOT_STRING_H */ -- 2.1.4