Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934666AbcLWLcR (ORCPT ); Fri, 23 Dec 2016 06:32:17 -0500 Received: from mga14.intel.com ([192.55.52.115]:29033 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbcLWLcQ (ORCPT ); Fri, 23 Dec 2016 06:32:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,393,1477983600"; d="scan'208";a="22053631" Subject: Re: [v1] i2c: busses: i2c-designware-pcidrv:- Unmap region obtained by pcim_iomap_regions To: Mika Westerberg , Arvind Yadav References: <1482487893-17589-1-git-send-email-arvind.yadav.cs@gmail.com> <20161223104449.GV1460@lahna.fi.intel.com> Cc: wsa@the-dreams.de, andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org From: Jarkko Nikula Message-ID: Date: Fri, 23 Dec 2016 13:27:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161223104449.GV1460@lahna.fi.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 455 Lines: 12 On 12/23/2016 12:44 PM, Mika Westerberg wrote: > On Fri, Dec 23, 2016 at 03:41:33PM +0530, Arvind Yadav wrote: >> Release IO memory mapping, if i2c_dw_pci_probe is not successful. > > Point of pcim_iomap_regions() is that the regions are released > automatically. So there is no need for explicit release. > Please see commit 76cf3fc844a4 ("i2c-designware-pci: use managed functions pcim_* and devm_*") how it simplified error handling here. -- Jarkko