Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941113AbcLWMNY (ORCPT ); Fri, 23 Dec 2016 07:13:24 -0500 Received: from merlin.infradead.org ([205.233.59.134]:37278 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753053AbcLWMNX (ORCPT ); Fri, 23 Dec 2016 07:13:23 -0500 Date: Fri, 23 Dec 2016 13:13:07 +0100 From: Peter Zijlstra To: Nicolai =?iso-8859-1?Q?H=E4hnle?= Cc: linux-kernel@vger.kernel.org, Nicolai =?iso-8859-1?Q?H=E4hnle?= , Ingo Molnar , Maarten Lankhorst , Daniel Vetter , Chris Wilson , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 05/12] locking/ww_mutex: Remove the __ww_mutex_lock inline wrappers Message-ID: <20161223121307.GO3107@twins.programming.kicks-ass.net> References: <1482346000-9927-1-git-send-email-nhaehnle@gmail.com> <1482346000-9927-6-git-send-email-nhaehnle@gmail.com> <20161223104844.GN3107@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 27 On Fri, Dec 23, 2016 at 12:16:03PM +0100, Nicolai Hähnle wrote: > >For some reason this patch appears to make lib/locking-selftest.c really > >unhappy. > > > >I get endless streams of: > > > >../lib/locking-selftest.c: In function ‘ww_test_fail_acquire’: > >../lib/locking-selftest.c:1141:6: error: void value not ignored as it ought to be > > ret = WWL(&o, &t); > > ^ > > > >Apparently GCC gets confused about __much_check on inline functions or > >something, or I got the patch wrong. > > Weird, I'm not getting that, and it makes no sense either from a quick > glimpse of the code. Is there anything beside > CONFIG_DEBUG_LOCKING_API_SELFTESTS I would have to enable to trigger this? Not entirely sure, I'm building an allmodconfig. > FWIW: > > $ gcc --version > gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 gcc (Debian 6.2.1-5) 6.2.1 20161124