Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965515AbcLWPya (ORCPT ); Fri, 23 Dec 2016 10:54:30 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36189 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938908AbcLWPy3 (ORCPT ); Fri, 23 Dec 2016 10:54:29 -0500 Subject: Re: [PATCH net 3/9] virtio-net: fix page miscount during XDP linearizing To: Jason Wang , mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1482503852-12438-1-git-send-email-jasowang@redhat.com> <1482503852-12438-4-git-send-email-jasowang@redhat.com> Cc: john.r.fastabend@intel.com From: John Fastabend Message-ID: <585D48A7.3040701@gmail.com> Date: Fri, 23 Dec 2016 07:54:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1482503852-12438-4-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 17 On 16-12-23 06:37 AM, Jason Wang wrote: > We don't put page during linearizing, the would cause leaking when > xmit through XDP_TX or the packet exceeds PAGE_SIZE. Fix them by > put page accordingly. Also decrease the number of buffers during > linearizing to make sure caller can free buffers correctly when packet > exceeds PAGE_SIZE. With this patch, we won't get OOM after linearize > huge number of packets. > > Cc: John Fastabend > Signed-off-by: Jason Wang > --- Thanks! looks good. By the way do you happen to have any actual configuration where this path is hit? I obviously didn't test this very long other than a quick test with my hacked vhost driver. Acked-by: John Fastabend