Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932539AbcLWQxN (ORCPT ); Fri, 23 Dec 2016 11:53:13 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33268 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597AbcLWQxL (ORCPT ); Fri, 23 Dec 2016 11:53:11 -0500 Subject: Re: [PATCH net 9/9] virtio-net: XDP support for small buffers To: Jason Wang , mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1482503852-12438-1-git-send-email-jasowang@redhat.com> <1482503852-12438-10-git-send-email-jasowang@redhat.com> Cc: john.r.fastabend@intel.com From: John Fastabend Message-ID: <585D562F.6000009@gmail.com> Date: Fri, 23 Dec 2016 08:51:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1482503852-12438-10-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 620 Lines: 16 On 16-12-23 06:37 AM, Jason Wang wrote: > Commit f600b6905015 ("virtio_net: Add XDP support") leaves the case of > small receive buffer untouched. This will confuse the user who want to > set XDP but use small buffers. Other than forbid XDP in small buffer > mode, let's make it work. XDP then can only work at skb->data since > virtio-net create skbs during refill, this is sub optimal which could > be optimized in the future. > > Cc: John Fastabend > Signed-off-by: Jason Wang > --- Looks good to me thanks! Acked-by: John Fastabend