Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S942100AbcLWSJL (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Dec 2016 13:09:11 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:37460 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753253AbcLWSJK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Dec 2016 13:09:10 -0500
Date: Fri, 23 Dec 2016 19:09:23 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: #ifdef out dw8250_acpi_match if ACPI
 isn't set
Message-ID: <20161223180923.GA26878@kroah.com>
References: <20161223123355.1370-1-jszhang@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161223123355.1370-1-jszhang@marvell.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 401
Lines: 11

On Fri, Dec 23, 2016 at 08:33:55PM +0800, Jisheng Zhang wrote:
> dw8250_acpi_match is used only when ACPI is enabled. Fix the following
> gcc warning when W=1 is set:
> 
> drivers/tty/serial/8250/8250_dw.c:640:36: warning: 'dw8250_acpi_match'
> defined but not used [-Wunused-const-variable=]

Don't set W=1 then, this type of "fix" is foolish and is just going to
make code messier, sorry.

greg k-h