Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965682AbcLXBTC (ORCPT ); Fri, 23 Dec 2016 20:19:02 -0500 Received: from matrix.voodoobox.net ([75.127.97.206]:53788 "EHLO voodoobox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965478AbcLXBTA (ORCPT ); Fri, 23 Dec 2016 20:19:00 -0500 X-Greylist: delayed 766 seconds by postgrey-1.27 at vger.kernel.org; Fri, 23 Dec 2016 20:18:59 EST Message-ID: <1482541554.16278.2.camel@dillow-glaptop.roam.corp.google.com> Subject: Re: [PATCH] drivers: net: ethernet: 3com: fix return value From: David Dillow To: Thomas Preisner Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de, milan.stephan+linux@fau.de Date: Fri, 23 Dec 2016 17:05:54 -0800 In-Reply-To: <1482534015-7828-1-git-send-email-thomas.preisner+linux@fau.de> References: <1482534015-7828-1-git-send-email-thomas.preisner+linux@fau.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1200 Lines: 33 On Sat, 2016-12-24 at 00:00 +0100, Thomas Preisner wrote: > diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c > index a0cacbe..9a3ab58 100644 > --- a/drivers/net/ethernet/3com/typhoon.c > +++ b/drivers/net/ethernet/3com/typhoon.c > @@ -2404,6 +2404,7 @@ typhoon_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > > if(!is_valid_ether_addr(dev->dev_addr)) { > err_msg = "Could not obtain valid ethernet address, aborting"; > + err = -EIO; > goto error_out_reset; The change above is fine, but the other two should use the return value from the failing function call. > @@ -2413,6 +2414,7 @@ typhoon_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > INIT_COMMAND_WITH_RESPONSE(&xp_cmd, TYPHOON_CMD_READ_VERSIONS); > if(typhoon_issue_command(tp, 1, &xp_cmd, 3, xp_resp) < 0) { > err_msg = "Could not get Sleep Image version"; > + err = -EIO; > goto error_out_reset; > } > > @@ -2455,6 +2457,7 @@ typhoon_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > > if(register_netdev(dev) < 0) { > err_msg = "unable to register netdev"; > + err = -EIO; > goto error_out_reset; > } >