Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbcLXHtq (ORCPT ); Sat, 24 Dec 2016 02:49:46 -0500 Received: from smtprelay0135.hostedemail.com ([216.40.44.135]:52239 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750976AbcLXHto (ORCPT ); Sat, 24 Dec 2016 02:49:44 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3866:3867:3868:3871:3873:3874:4321:5007:7903:10004:10400:10848:11026:11232:11658:11914:12043:12740:12760:12895:13069:13255:13311:13357:13439:14659:14721:21080:21434:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: love81_71bf3f4882a54 X-Filterd-Recvd-Size: 1579 Message-ID: <1482565780.1928.1.camel@perches.com> Subject: Re: [PATCH] pci: hotplug: This patch removes unnecessary return statement using spatch tool From: Joe Perches To: Rahul Krishnan , bhelgaas@google.com Cc: mpe@ellerman.id.au, mika.westerberg@linux.intel.com, gwshan@linux.vnet.ibm.com, mayurkumar.patel@intel.com, keith.busch@intel.com, julia.lawall@lip6.fr, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 23 Dec 2016 23:49:40 -0800 In-Reply-To: <20161224073307.GA18826@rahul> References: <20161224073307.GA18826@rahul> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 622 Lines: 23 On Sat, 2016-12-24 at 13:03 +0530, Rahul Krishnan wrote: > This patch removes unnecessary return statement using spatch tool [] > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c [] > @@ -463,8 +463,7 @@ int __init rpadlpar_io_init(void) > return -EPERM; > } > > - rc = dlpar_sysfs_init(); > - return rc; > + return dlpar_sysfs_init(); > } > > void rpadlpar_io_exit(void) If you are going to submit these types of patches, please make sure you compile test them before sending so that you can look at new warnings. Now rc is unused and its declaration should be removed.