Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242AbcLXJ0F (ORCPT ); Sat, 24 Dec 2016 04:26:05 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:33557 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176AbcLXJ0C (ORCPT ); Sat, 24 Dec 2016 04:26:02 -0500 Date: Sat, 24 Dec 2016 11:25:53 +0200 From: Krzysztof Kozlowski To: Pankaj Dubey Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, krzk@kernel.org, kgene@kernel.org, jingoohan1@gmail.com, bhelgaas@google.com, jh80.chung@samsung.com, alim.akhtar@samsung.com, sanath@samsung.com, Niyas Ahmed S T Subject: Re: [PATCH] PCI: exynos: refactor exynos pcie driver Message-ID: <20161224092553.GA4858@kozik-lap> References: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1775 Lines: 58 On Fri, Dec 23, 2016 at 04:26:27PM +0530, Pankaj Dubey wrote: > From: Niyas Ahmed S T > > Currently Exynos PCIe driver is only supported for Exynos5440 SoC. > This patch does refactoring of Exynos PCIe driver to extend support > for other Exynos SoC. > > Following are the main changes done via this patch: > 1) It adds separate structs for memory, clock resources. > 2) It add exynos_pcie_ops struct which will allow us to support the > differences in resources in different Exynos SoC. > > No functional change intended. > > Signed-off-by: Niyas Ahmed S T > Signed-off-by: Pankaj Dubey > --- > This patch set is prepared on top of Krzysztof's for-next and > PCIe driver cleanup patch [1] by Jaehoon Chung. > > [1]: https://lkml.org/lkml/2016/12/19/44 > > > drivers/pci/host/pci-exynos.c | 346 ++++++++++++++++++++++++++---------------- > 1 file changed, 217 insertions(+), 129 deletions(-) (...) > @@ -573,14 +660,15 @@ static int __exit exynos_pcie_remove(struct platform_device *pdev) > { > struct exynos_pcie *exynos_pcie = platform_get_drvdata(pdev); > > - clk_disable_unprepare(exynos_pcie->bus_clk); > - clk_disable_unprepare(exynos_pcie->clk); > + if (exynos_pcie->ops && exynos_pcie->ops->deinit_clk_resources) > + exynos_pcie->ops->deinit_clk_resources(exynos_pcie); > > return 0; > } > > static const struct of_device_id exynos_pcie_of_match[] = { > - { .compatible = "samsung,exynos5440-pcie", }, > + { .compatible = "samsung,exynos5440-pcie", > + .data = &exynos5440_pcie_ops }, A nit, please put brackets in new lines, so: { ... }, Acked-by: Krzysztof Kozlowski I didn't do a thorough review, though. Best regards, Krzysztof