Message-ID: <3EC4F1FD.4010603@inet6.fr>
Date: Fri, 16 May 2003 16:13:17 +0200
From: Lionel Bouton <Lionel.Bouton@inet6.fr>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030314
MIME-Version: 1.0
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: alan@lxorguk.ukuu.org.uk, marcelo@conectiva.com.br, torvalds@transmeta.com,
       linux-kernel@vger.kernel.org
Subject: Re: [patch] Fix support for SiS5581/5582/5596 IDE
References: <20030516160222.A19746@ucw.cz>
In-Reply-To: <20030516160222.A19746@ucw.cz>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 942
Lines: 27

Vojtech Pavlik wrote:

>Hi!
>
>The last patch for SiS96* also added support for SiS5581, SiS5582 and
>SiS5596. However, the PCI IDs for these three chips were incorrect by
>mistake (cut and paste problem). This patch, on top of the previous one
>fixes it, and thus adds proper support for these old chips.
>  
>

Thanks for the work.
I've yet to read carefully each change (will do this week-end), but I 
agree on the principles.

The only thing that disturbed me was the removal of the DEBUG code (as 
it often helped me find out bugs and understand new chips' behavior) but 
I think it's best for me to maintain a patch which adds this code in the 
very rare cases where it can be usefull.

LB.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/