From: Duncan Sands <baldrick@wanadoo.fr>
To: chas williams <chas@locutus.cmf.nrl.navy.mil>, Greg KH <greg@kroah.com>,
       davem@redhat.com
Subject: Re: [PATCH][ATM] add reference counting to atm_dev
Date: Fri, 16 May 2003 16:40:43 +0200
User-Agent: KMail/1.5.1
Cc: linux-kernel@vger.kernel.org
References: <200305151432.h4FEW5Gi012599@locutus.cmf.nrl.navy.mil>
In-Reply-To: <200305151432.h4FEW5Gi012599@locutus.cmf.nrl.navy.mil>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200305161640.43804.baldrick@wanadoo.fr>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1224
Lines: 26

On Thursday 15 May 2003 16:32, chas williams wrote:
> In message <20030515052041.GA5995@kroah.com>,Greg KH writes:
> >It's not really bothering me, just wondering when it will go away (I see
> >it when building one of the USB ATM drivers...)
>
> the MOD_* functions in the speedtch driver don't need to be there.
> since 2.3.something (if i remember correctly) the reference counting
> has been handled by the upper layer (ala fops_get/fops_put).  the
> following patch removes these extra bits:

Hi Chas, thanks for the patch.  I agree that it is correct.  However,
I was wondering about ioctl and proc calls.  Can the ATM layer call
a driver's ioctl routine before opening a vcc?  If so, does it take a
reference to the module first (I didn't spot anything)?  Also, are
calls to a driver's proc_read routine protected against module
unloading races (I confess I didn't take the time to look into this,
because my own driver does not sleep in proc_read)?

All the best,

Duncan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/