Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753785AbcLYA47 (ORCPT ); Sat, 24 Dec 2016 19:56:59 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:49074 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbcLYA45 (ORCPT ); Sat, 24 Dec 2016 19:56:57 -0500 Date: Sat, 24 Dec 2016 19:56:54 -0500 (EST) Message-Id: <20161224.195654.1632303818126752071.davem@davemloft.net> To: thomas.preisner+linux@fau.de Cc: sergei.shtylyov@cogentembedded.com, dave@thedillows.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de, milan.stephan+linux@fau.de Subject: Re: [PATCH v3 1/2] drivers: net: ethernet: 3com: fix return value From: David Miller In-Reply-To: <1482625822-19658-2-git-send-email-thomas.preisner+linux@fau.de> References: <4200be74-f7e7-db6b-a258-8fd178fef369@cogentembedded.com> <1482625822-19658-1-git-send-email-thomas.preisner+linux@fau.de> <1482625822-19658-2-git-send-email-thomas.preisner+linux@fau.de> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 24 Dec 2016 15:57:41 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 351 Lines: 10 It is never, ever, appropriate to use the same exact Subject: line text for two different changes. Someone looking at "git shortlog" has no way to know what is different between the two changes. You must put care and time into constructing Subject: lines because this text is critical for data mining and analysis done by both humans and machines.