Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932172AbcLYCHd (ORCPT ); Sat, 24 Dec 2016 21:07:33 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:50990 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbcLYCHc (ORCPT ); Sat, 24 Dec 2016 21:07:32 -0500 Date: Sat, 24 Dec 2016 21:07:28 -0500 (EST) Message-Id: <20161224.210728.1213063344392674330.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv4: Namespaceify tcp_tw_reuse knob From: David Miller In-Reply-To: <1482583387-79777-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1482583387-79777-1-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 24 Dec 2016 17:08:16 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 409 Lines: 10 From: Haishuang Yan Date: Sat, 24 Dec 2016 20:43:07 +0800 > Signed-off-by: Haishuang Yan You need to provide something more than an empty commit message. Instead, the commit message must explain why this particular sysctl should be considered for namespacification and what the implications, both good and bad, are for such a change.