Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753358AbcLYKHY (ORCPT ); Sun, 25 Dec 2016 05:07:24 -0500 Received: from mail-lf0-f52.google.com ([209.85.215.52]:36657 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932155AbcLYKHV (ORCPT ); Sun, 25 Dec 2016 05:07:21 -0500 Subject: Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value To: Thomas Preisner References: <4200be74-f7e7-db6b-a258-8fd178fef369@cogentembedded.com> <1482625822-19658-1-git-send-email-thomas.preisner+linux@fau.de> <1482625822-19658-3-git-send-email-thomas.preisner+linux@fau.de> Cc: dave@thedillows.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de, milan.stephan+linux@fau.de From: Sergei Shtylyov Message-ID: Date: Sun, 25 Dec 2016 13:07:17 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1482625822-19658-3-git-send-email-thomas.preisner+linux@fau.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 706 Lines: 19 Hello! On 12/25/2016 3:30 AM, Thomas Preisner wrote: > In some cases the return value of a failing function is not being used > and the function typhoon_init_one() returns another negative error > code instead. > > Signed-off-by: Thomas Preisner > Signed-off-by: Milan Stephan > --- > drivers/net/ethernet/3com/typhoon.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) In addition to what DaveM said, your choise of the subject prefixes is too wide -- it would seem that you're fixing all 3com drivers, while you're only fixing typhoon. That "typhoon:" alone would have been an appropriate prefix. MBR, Sergei