Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753682AbcLYUOP (ORCPT ); Sun, 25 Dec 2016 15:14:15 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:42766 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbcLYUOO (ORCPT ); Sun, 25 Dec 2016 15:14:14 -0500 Date: Sun, 25 Dec 2016 20:14:09 +0000 From: Al Viro To: Scott Matheina Cc: linux-kernel@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCHv4 2/8] Fixed variables not being consistently lower case Message-ID: <20161225201409.GL1555@ZenIV.linux.org.uk> References: <1482694902-7400-1-git-send-email-scott@matheina.com> <1482694902-7400-3-git-send-email-scott@matheina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482694902-7400-3-git-send-email-scott@matheina.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 680 Lines: 13 On Sun, Dec 25, 2016 at 01:41:06PM -0600, Scott Matheina wrote: > Across the file, variables were sometimes upper case, some times > lower case, this fix addresses a few of the instances with this > inconsistency. NAK. Go learn C and don't come back until you've done that. If somebody has told you that you can contribute without knowing the language, they'd lied - you really can't. And I would *STRONGLY* recommend to stay away from drivers/staging while you are learning C - it's like trying to use a public restroom wall as a sex-ed textbook. While we are at it, it might be a good idea to check if the kernel builds after your changes and see what errors are produced.