Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754922AbcLZDbr (ORCPT ); Sun, 25 Dec 2016 22:31:47 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:2591 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754052AbcLZDbp (ORCPT ); Sun, 25 Dec 2016 22:31:45 -0500 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Sun, 25 Dec 2016 19:31:44 -0800 Subject: Re: [PATCH v2 0/4] vfio-mdev: Fix remove race, clean namespace and better define ABI To: Alex Williamson References: <20161222201809.15541.22506.stgit@gimli.home> CC: , , X-Nvconfidentiality: public From: Kirti Wankhede Message-ID: Date: Mon, 26 Dec 2016 09:01:35 +0530 MIME-Version: 1.0 In-Reply-To: <20161222201809.15541.22506.stgit@gimli.home> X-Originating-IP: [10.25.75.102] X-ClientProxiedBy: BGMAIL103.nvidia.com (10.25.59.12) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1582 Lines: 42 On 12/23/2016 1:51 AM, Alex Williamson wrote: > Cleanup the namespace a bit by prefixing structures with mdev_ and > also more concretely define the mdev interface. Structs with comments > defining which fields are private vs public tempts poor behavior, > especially for an interface where we expect out of tree vendor drivers. > Patch 2/4-4/4 looks good to me. Reviewed by: Kirti Wankhede Thanks, Kirti > Additionally in v2, the patch removing the next field from mdev_device > is dropped, instead using it to fix a remove race, my From address is > fixed, and Documentation is updated. Jike, I left your R-b on the > patches that didn't change only. If I've missed any relevant doc > updates, please let me know. Thanks, > > Alex > > --- > > Alex Williamson (4): > vfio-mdev: Fix remove race > vfio-mdev: de-polute the namespace, rename parent_device & parent_ops > vfio-mdev: Make mdev_parent private > vfio-mdev: Make mdev_device private and abstract interfaces > > > Documentation/vfio-mediated-device.txt | 27 +++++---- > drivers/gpu/drm/i915/gvt/kvmgt.c | 22 ++++--- > drivers/vfio/mdev/mdev_core.c | 100 +++++++++++++++++++++++++++----- > drivers/vfio/mdev/mdev_private.h | 29 ++++++++- > drivers/vfio/mdev/mdev_sysfs.c | 8 +-- > drivers/vfio/mdev/vfio_mdev.c | 12 ++-- > include/linux/mdev.h | 54 ++++------------- > samples/vfio-mdev/mtty.c | 28 +++++---- > 8 files changed, 173 insertions(+), 107 deletions(-) >