Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751577AbcLZFTY (ORCPT ); Mon, 26 Dec 2016 00:19:24 -0500 Received: from smtpout.microchip.com ([198.175.253.82]:44725 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750713AbcLZFTW (ORCPT ); Mon, 26 Dec 2016 00:19:22 -0500 From: To: , CC: , , Subject: RE: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly Thread-Topic: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly Thread-Index: AQHSXCdABiqLRcH9F0mRN7TRqDhgbqEUrkSAgAA1YQCAAWeYAIADanSg Date: Mon, 26 Dec 2016 05:19:20 +0000 Message-ID: References: <1482392635-20521-1-git-send-email-peda@axentia.se> <20161222172705.GA17046@kroah.com> <0697753c-ea66-805d-a366-7de708efc066@axentia.se> <20161223180510.GE26271@kroah.com> In-Reply-To: <20161223180510.GE26271@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.215.90] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uBQ5JUN8030977 Content-Length: 2309 Lines: 63 > -----Original Message----- > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > Sent: 2016??12??24?? 2:05 > To: Peter Rosin > Cc: linux-kernel@vger.kernel.org; Alan Stern ; > linux-usb@vger.kernel.org; Wenyou Yang - A41535 > > Subject: Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor- > based gpio APIs correctly > > On Thu, Dec 22, 2016 at 09:38:08PM +0100, Peter Rosin wrote: > > On 2016-12-22 18:27, Greg Kroah-Hartman wrote: > > > On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: > > >> The gpiod_get* function family does not want the -gpio suffix. > > >> Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional. > > >> The descriptor based APIs handle active high/low automatically. > > >> The vbus-gpios are output, request enable while getting the gpio. > > >> Don't try to get any vbus-gpios for ports outside num-ports. > > >> > > >> WTF? Big sigh. > > >> > > >> Fixes: 054d4b7b577d ("usb: ohci-at91: Use descriptor-based gpio > > >> APIs") > > >> Signed-off-by: Peter Rosin > > >> --- > > >> > > >> Hi! > > >> > > >> Resending this, since the only response I've got is that the merge > > >> window is open and that this patch has been put on hold due to that. > > >> But I think this regression (which happend between v4.9 and current > > >> master) should be fixed before the merge window closes. > > > > > > I don't merge patches before -rc1 comes out, sorry, people should > > > have tested linux-next better :) > > > > Neat, shift the blame for the shit patch over to the messenger :) > > Not at all, I blame the original developer :) I am very very sorry. It is my ignorance. Sorry. I tested this patch on linux-next branch on the SAMA5D3 and SAMA5D4 Xplained board. > > > > I'll catch up the first week of January, relax. > > > > As we all know, unrelated regressions are painful when trying to > > locate other problems. It's seems silly to have a few extra for no good reason. > > I am supposed to be on vacation and not reading email until the 3rd of January, > relax, we will catch up on stuff like this, and other minor things, soon enough, in > plenty of time for 4.10-final. > > thanks, > > greg k-h Best Regards, Wenyou Yang