From: "Koteshwar Rao, Satha" <Satha.Rao@cavium.com>
To: Sunil Kovvuri <sunil.kovvuri@gmail.com>
CC: LKML <linux-kernel@vger.kernel.org>,
        "Goutham, Sunil" <Sunil.Goutham@cavium.com>,
        Robert Richter <rric@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "Daney, David" <David.Daney@cavium.com>,
        "Vatsavayi, Raghu" <Raghu.Vatsavayi@cavium.com>,
        "Chickles, Derek" <Derek.Chickles@cavium.com>,
        "Romanov, Philip" <Philip.Romanov@cavium.com>,
        Linux Netdev List <netdev@vger.kernel.org>,
        LAKML <linux-arm-kernel@lists.infradead.org>
Subject: RE: [RFC PATCH 5/7] Multiple VF's grouped together under single
 physical port called PF group PF Group maintainance API's
Thread-Topic: [RFC PATCH 5/7] Multiple VF's grouped together under single
 physical port called PF group PF Group maintainance API's
Thread-Index: AQHSW2cADvMHs4Nv2EurvrCGM2YsqaESWO2AgAf0/uA=
Date: Mon, 26 Dec 2016 14:16:04 +0000
Message-ID: <DM5PR07MB2842A6B6A87F51FDB513B55A8D960@DM5PR07MB2842.namprd07.prod.outlook.com>
References: <1482310011-1862-1-git-send-email-satha.rao@caviumnetworks.com>
 <1482310011-1862-6-git-send-email-satha.rao@caviumnetworks.com>
 <CA+sq2Cf=3-WUaT+iNefYswgGf2ejW6EQp1igcMWELU=-xUnnNA@mail.gmail.com>
In-Reply-To: <CA+sq2Cf=3-WUaT+iNefYswgGf2ejW6EQp1igcMWELU=-xUnnNA@mail.gmail.com>
Accept-Language: en-US, en-GB
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2016 14:16:04.1961
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB2940
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uBQEGNWb004918
Content-Length: 1007
Lines: 27

Thanks for suggestion. Will clean up code in next revision

Thanks,
Satha

-----Original Message-----
From: Sunil Kovvuri [mailto:sunil.kovvuri@gmail.com] 
Sent: Wednesday, December 21, 2016 4:44 AM
To: Koteshwar Rao, Satha
Cc: LKML; Goutham, Sunil; Robert Richter; David S. Miller; Daney, David; Vatsavayi, Raghu; Chickles, Derek; Romanov, Philip; Linux Netdev List; LAKML
Subject: Re: [RFC PATCH 5/7] Multiple VF's grouped together under single physical port called PF group PF Group maintainance API's

On Wed, Dec 21, 2016 at 2:16 PM, Satha Koteswara Rao <satha.rao@caviumnetworks.com> wrote:
> +struct tns_global_st {
> +       u64 magic;
> +       char     version[16];
> +       u64 reg_cnt;
> +       struct table_static_s tbl_info[TNS_MAX_TABLE]; };
> +
> +#define PF_COUNT 3
> +#define PF_1   0
> +#define PF_2   64
> +#define PF_3   96
> +#define PF_END 128

Some comments please ... what is 0, 64, 96 ??
You can read PCI_SRIOV_TOTAL_VF from PCI config space instead of defining PF_END with 128.