Date: Fri, 16 May 2003 19:14:36 +0200 (MET DST)
From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Vojtech Pavlik <vojtech@suse.cz>
cc: <Lionel.Bouton@inet6.fr>, <alan@lxorguk.ukuu.org.uk>,
       <marcelo@conectiva.com.br>, <torvalds@transmeta.com>,
       <linux-kernel@vger.kernel.org>
Subject: Re: [patch] Support for SiS 961/961B/962/963/630S/630ET/633/733 IDE
In-Reply-To: <20030516143021.A17346@ucw.cz>
Message-ID: <Pine.SOL.4.30.0305161903590.16125-100000@mion.elka.pw.edu.pl>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 878
Lines: 28


Hi,

Good job, but...

On Fri, 16 May 2003, Vojtech Pavlik wrote:
> And while doing the changes I did also some cleanups, mainly removing a
> bunch of debug code that doesn't seem very useful when lspci does the
> same job. And removing the config_drive_xfer_rate in favor of functions
> from ide-timing.h.

Debug code in fe. SiS IDE driver does the same as lspci given you get to
the point you can run lspci. Dumping of PCI conf regs should be moved to
generic IDE PCI code as it might be useful for other IDE PCI drivers.

Removing config_drive_xfer_rate() is bad,
fe. you don't check for bad drives now.

Regards,
--
Bartlomiej


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/