Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754709AbcLZOXu (ORCPT ); Mon, 26 Dec 2016 09:23:50 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:56854 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751894AbcLZOXs (ORCPT ); Mon, 26 Dec 2016 09:23:48 -0500 Date: Mon, 26 Dec 2016 14:23:43 +0000 From: Al Viro To: Hanjun Guo Cc: Kefeng Wang , Linus Torvalds , Linux Kernel Mailing List , Will Deacon , Catalin Marinas Subject: Re: Linux 4.10-rc1 Message-ID: <20161226142343.GP1555@ZenIV.linux.org.uk> References: <5860D6F5.1050705@huawei.com> <2a166af6-380d-3ce2-abd0-086041f14f05@huawei.com> <20161226091854.GO1555@ZenIV.linux.org.uk> <5860E6A6.4020905@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5860E6A6.4020905@huawei.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 555 Lines: 15 On Mon, Dec 26, 2016 at 05:45:10PM +0800, Hanjun Guo wrote: > On 2016/12/26 17:18, Al Viro wrote: > > On Mon, Dec 26, 2016 at 05:05:37PM +0800, Kefeng Wang wrote: > >> It looks like we need revert the changes from assembly files. > > I tested Kefeng's patch and works. more comments below. > > > Better yet, split the damn thing in two and include the asm-only part. > > split will cause other places for building errors, because there is no > > -#ifndef __ASSEMBLY__ Huh? It's included only from assembler files, so what would use the other parts?