Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755877AbcLZUyq (ORCPT ); Mon, 26 Dec 2016 15:54:46 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:41889 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755778AbcLZUyo (ORCPT ); Mon, 26 Dec 2016 15:54:44 -0500 Subject: Re: [GIT pull] smp/hotplug: Removal of notifiers To: Thomas Gleixner References: <20161226074530.GA297@x4> <20161226110600.GB297@x4> <20161226154502.GA287@x4> <53e3b52b-f353-63c8-f96f-649d754596bc@oracle.com> Cc: Markus Trippelsdorf , Linus Torvalds , LKML , Ingo Molnar , "H. Peter Anvin" , Sebastian Andrzej Siewior , Borislav Petkov From: Boris Ostrovsky Message-ID: <1c76c271-8e04-ddb5-ab4f-c8a0fe99c23f@oracle.com> Date: Mon, 26 Dec 2016 15:53:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 964 Lines: 28 On 12/26/2016 01:21 PM, Thomas Gleixner wrote: > On Mon, 26 Dec 2016, Boris Ostrovsky wrote: >> On 12/26/2016 10:45 AM, Markus Trippelsdorf wrote: >>> The comment in arch/x86/kernel/cpu/mcheck/mce_amd.c says: >>> >>> 1384 * mcheck_init_device should be inited before threshold_init_device to >>> 1385 * initialize mce_device, otherwise a NULL ptr dereference will cause panic. > > That's not changed by this commit. > >> My nightly test hit this as well. AMD only, Intel passed. I haven't >> verified whether commit that Markus implicated is the one that caused >> this but it's the same BUG signature (but possibly slightly different stack) >> >> [ 1.554351] smpboot: CPU0: AMD Engineering Sample (family: 0x10, >> model: 0x4, stepping: 0x1) >> ... > > Is there anything interesting error message before the BUG hits? I'll try > to reproduce on a AMD box tomorrow. Nothing that caught my eye. I can post it tomorrow if you are still interested. -boris