Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755624AbcLZWET (ORCPT ); Mon, 26 Dec 2016 17:04:19 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:52079 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbcLZWES (ORCPT ); Mon, 26 Dec 2016 17:04:18 -0500 Date: Mon, 26 Dec 2016 23:04:04 +0100 (CET) From: Stefan Wahren To: Alexey Khoroshilov , Jonathan Cameron , Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org, linux-iio@vger.kernel.org, lee.jones@linaro.org Message-ID: <1600801097.88831.1482789844722@email.1und1.de> In-Reply-To: <1482531319-26935-1-git-send-email-khoroshilov@ispras.ru> References: <1482531319-26935-1-git-send-email-khoroshilov@ispras.ru> Subject: Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.1-Rev28 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K0:3d4iLujzE2QvYywiXaKm4vUaRh2EU98k75hA1NUn4VNiWn0ZtH0 yQKXzyI010cJ6fZtAqYdWHB7nGo69+n3jCwyxcGXBOLcb3xYF0IrJAzTPZU1OLsFnWObjd2 wp3GbgxOOsS+zkEg5beg2+FNOdjlDPUJchPkSLmEKgQRq+Eme8NTKmmuRkuLfFaphrnXYgo NcOGXJvrSflcjmgnwS1bA== X-UI-Out-Filterresults: notjunk:1;V01:K0:AvI6PMU3OyU=:31Y9zx0TV6Vqj/WGcFuOEQ vw0UH7a22ZwzymM6UO37JB4KTGLFDhNQcWJgfwR+vpTrZpXLH4P724+47FYNBM9mwZFNHCmar EckrhMUwl4YnN/XApevs8BL3C1WGtHWS8H3lkcXvfPTwBOqnIrV6Q6ziUaOIZll7gS7127H4B Ue121imqo+01MelgGbzxFdiBX/G1+SDpLFkzTWAZM/e2CaL4QjgFTcCPJLfZFVf7d21zFlpI4 8MapXhkdocNSIXKbNd2Jm8/d+cF3TqphrAcE+SA7d/RSMhH+zl65VPUf8IFzYQ5Yi6JpYhU9o uD9nvj+XPkg5PGyMKaL5tBiPbLopk0pTx4PQ1tSTNepJbFVyHx7stDA/GoIDAxnEufcgsQbyo e344zLaFnG8xerT1PAMrBYxW6A++PF04i4ERZrQ/lwkebKtfEjBHbnpKGDG0QiVfkyqUD3TSB zq4FOQYCrnMtEfRiLF/7/mGob1lggVxGBFeQA05ZPH8Dp/Lxo/JF1fIFFKB7lKw7MdYFiBJ3+ Zinev7OWo47V+QotnkwGMdn463spjprXobxMcGTAJhWmFcIPvvfuQBdOrHAFy5cJdqbboG00I vCM5Z2tFc7I7x/bH3fpzXbkf7EG6peE/5vOJLPBLIQ86dimK1x53j5i9RjM3e7KTM5Qnh3axf OFbQWyNZOI8dILpzJihwjvACN19UK+Ezc0/nGesmilCUiwIIBgMSk9jWR+EHQYxza4Orvyc0Z d3rqenFMsRjgguL4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 21 > Alexey Khoroshilov hat am 23. Dezember 2016 um 23:15 geschrieben: > > > During transition to using devm_input_allocate_device() > goto to resource deallocation block was replaced by return > in case of error in iio_device_register(). > That is wrong since resources are left undeallocated. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > Fixes: 962ed43a3eac ("iio: mxs-lradc: remove mxs_lradc_ts_unregister") Acked-by: Stefan Wahren But since Ksenija's patch series [1] (which doesn't have this issue) this patch is only relevant for stable. Thanks [1] - http://marc.info/?l=linux-iio&m=148131774219426&w=2