Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754086AbcL0KSr (ORCPT ); Tue, 27 Dec 2016 05:18:47 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:40947 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753728AbcL0KSh (ORCPT ); Tue, 27 Dec 2016 05:18:37 -0500 X-AuditID: b6c32a2d-f79a76d0000074b4-21-58623ff9c1b0 Subject: Re: [PATCH] PCI: exynos: refactor exynos pcie driver To: Alim Akhtar , Pankaj Dubey , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Cc: krzk@kernel.org, kgene@kernel.org, jingoohan1@gmail.com, bhelgaas@google.com, sanath@samsung.com, Niyas Ahmed S T , CPGS From: Jaehoon Chung Message-id: Date: Tue, 27 Dec 2016 19:18:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: <58620B5A.1060900@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJJsWRmVeSWpSXmKPExsWy7bCmlu5P+6QIgxdbrCwezNvGZrGkKcPi 5SFNixVfZrJb9D9+zWxx/vwGdotNj6+xWlzeNYfN4uy842wWM87vY7J4MuURq8WirV/YLaat W8fswOuxc9Zddo8Fm0o9Nq3qZPPYvKTeo2/LKkaPz5vkAtiiUm0yUhNTUosUUvOS81My89Jt lbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgK5UUihLzCkFCgUkFhcr6dvZFOWXlqQq ZOQXl9gqRRsaGukZGpjrGRkZ6ZkYx1oZmQKVJKRmfLuyg7VgCWfF/RcHmBsYN7B3MXJySAiY SKyedYcJwhaTuHBvPVsXIxeHkMBSRokJz9ewQzjtTBIr+9eydjFygHUcPCcOEV/OKDHnx09m COceo8T27U/ARgkL2Eqc7trLBJIQEbjFKPFiUg9YFbPAGkaJM5cWMoJUsQnoSGz/dhysg1fA TmJt20Uwm0VAVWLP53tgtqhAmMTm+y/ZIWoEJX5MvscCcgangLbEzye8IGFmAQOJGVMOM0HY 8hKb17wF2yUhcItd4u6ZTcwQZ8tKbDrADPGni8TGI0dZIWxhiVfHt0DDQlri79JbjBC93YwS /75sZINwehglbm1dDQ0lY4n7D+4xQ2zjk+j9DfIyyAJeiY42IYgSD4ldD99DLXCUmLZ0OjRQ 5zFLTP7ymH0Co/wsJP/MQvLELCRPLGBkXsUollpQnJueWmxaYKRXnJhbXJqXrpecn7uJEZxM tXR3MH5Z4H2IUYCDUYmH98fyxAgh1sSy4srcQ4wSHMxKIrx9dkkRQrwpiZVVqUX58UWlOanF hxhNgWE8kVlKNDkfmOjzSuINTcwMTYwsgdDc0FxJnHdBhXWEkEB6YklqdmpqQWoRTB8TB6dU A6P8z+eC2etn7Nls3PfM31pEWt7bfuqrdV+1Uy8zxjv1ZpoI3u68/b2N74bm+uyfr46yuL2U dJd1FTK9Hn2xK0ZR7c/LqwFJpTNljop4SPxqvpkpUatsz3zQKM5K0NT5b76U5vrnbRdvrQ1N Ov70wJeFGe+D1ob3svgUyO/Q0W2z3V7Ee9MwQImlOCPRUIu5qDgRAFwSpL28AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t9jAd2f9kkRBvvmK1o8mLeNzWJJU4bF y0OaFiu+zGS36H/8mtni/PkN7BabHl9jtbi8aw6bxdl5x9ksZpzfx2TxZMojVotFW7+wW0xb t47Zgddj56y77B4LNpV6bFrVyeaxeUm9R9+WVYwenzfJBbBFudlkpCampBYppOYl56dk5qXb KoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5RgZowME5wD1YSd8uwS3j25UdrAVLOCvuvzjA 3MC4gb2LkYNDQsBE4uA58S5GTiBTTOLCvfVsXYxcHEICSxklDu1cww7hPGCUuPLhIxtIlbCA rcTprr1MIAkRgVuMEq1nepkhqhYwS2xdfAWshVlgDaPEhtbf7CAtbAI6Etu/HWcCsXkF7CTW tl0Es1kEVCX2fL7HBHKHqECYxPNGJ4gSQYkfk++xgIQ5BbQlfj7hBTGZBfQk7l/UAqlgFpCX 2LzmLfMERoFZSBpmIVTNQlK1gJF5FaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZwfD6T 3sF4eJf7IUYBDkYlHt6IjYkRQqyJZcWVuYcYJTiYlUR4++ySIoR4UxIrq1KL8uOLSnNSiw8x mgI9MZFZSjQ5H5g68kriDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhPLEnNTk0tSC2C6WPi4JRq YMz+V7WIV7OPafc+7RSOPPkw23wXf+F9Snqqu0UNGl//q5cterBC6ufcjKDLN6/a7JxgP3G/ +q1Av+ZEz+mRTiscVjya3V65ZFHdVwPTPbt7H8TvrX9vxqjp9XqndmvtobCiZ+yVP3Jeaa5c 63NHsqDQwmM2i2beSlafiHXuOhd0Lh9z1YsSUWIpzkg01GIuKk4EACV3W87lAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161227101833epcas5p3e969a73b316f04deff086cf81c7e6d85 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbUzUvU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20161223105411epcas1p3727f726e757ec6c6d7bff04a9af40077 X-RootMTR: 20161223105411epcas1p3727f726e757ec6c6d7bff04a9af40077 References: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com> <5860E6F7.2090703@samsung.com> <79b89c49-a9de-3daa-9afa-b8f36304a226@samsung.com> <5861CE23.9060202@samsung.com> <6de4bc5b-05fb-793f-d3ab-b1c6ee19cfeb@samsung.com> <58620B5A.1060900@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 38 Dear Alim, On 12/27/2016 03:34 PM, Alim Akhtar wrote: > Hi Jaehoon, > [snip] >> >> Ah. Right..And i'm doing the refactoring to reuse the current pci-exynos.c. > There is a nice refactoring patch posted by Pankaj recently @ > https://lkml.org/lkml/2016/12/23/73 > I would suggest you to rebase your work on this top. Well, i don't think so. Pankaj's patch might be good way..but i can't agree about a few point. If based on Pankaj's patch, it's more complex.. why put the ops callback for getting clock and mem resource? If PHY generic framework is used, it's unnecessary. because it needs to get elbi and dbi resources. clock resources("pcie" and "pcie_bus") are general things. If Pankaj's patch is applied, also need to make the exynos5433_pcie_* callback functions? It doesn't make sense. I want to know maintainer's opinion..we can just touch a little for supporting All Exynos SoCs. Best Regards, Jaehoon Chung > >> Maybe..Today or Tomorrow..I will send the patches..At that time, could you also check them? >> Any comments might be helpful to me! :) >> > Will wait for you patches :-) > >> Best Regards, >> Jaehoon Chung >> [snip]