Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755170AbcL0MtN (ORCPT ); Tue, 27 Dec 2016 07:49:13 -0500 Received: from mail-qk0-f175.google.com ([209.85.220.175]:34686 "EHLO mail-qk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754857AbcL0MtI (ORCPT ); Tue, 27 Dec 2016 07:49:08 -0500 MIME-Version: 1.0 In-Reply-To: <1481207730-6332-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1481207730-6332-1-git-send-email-arvind.yadav.cs@gmail.com> From: Linus Walleij Date: Tue, 27 Dec 2016 13:49:06 +0100 Message-ID: Subject: Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions To: Arvind Yadav , Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 562 Lines: 15 On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav wrote: > In functions pxa2xx_build_functions, the memory allocated for > 'functions' is live within the function only. After the > allocation it is immediately freed with devm_kfree. There is > no need to allocate memory for 'functions' with devm function > so replace devm_kcalloc with kcalloc and devm_kfree with kfree. > > Signed-off-by: Arvind Yadav I want the maintainer Robert Jarzmik to review this before I do anything with it. Yours, Linus Walleij