Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933193AbcL0QLl (ORCPT ); Tue, 27 Dec 2016 11:11:41 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33233 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933011AbcL0QG5 (ORCPT ); Tue, 27 Dec 2016 11:06:57 -0500 From: Ming Lei To: Jens Axboe , linux-kernel@vger.kernel.org Cc: linux-block@vger.kernel.org, Christoph Hellwig , Ming Lei , Johannes Berg Subject: [PATCH v1 14/54] block: introduce multipage/single page bvec helpers Date: Tue, 27 Dec 2016 23:56:03 +0800 Message-Id: <1482854250-13481-15-git-send-email-tom.leiming@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482854250-13481-1-git-send-email-tom.leiming@gmail.com> References: <1482854250-13481-1-git-send-email-tom.leiming@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3845 Lines: 102 This patch introduces helpers which are suffixed with _mp and _sp for the multipage bvec/segment support. The helpers with _mp suffix are the interfaces for treating one bvec/segment as real multipage one, for example, .bv_len is the total length of the multipage segment. The helpers with _sp suffix are interfaces for supporting current bvec iterator which is thought as singlepage only by drivers, fs, dm and etc. These _sp helpers are introduced to build singlepage bvec in flight, so users of bio/bvec iterator still can work well and needn't change even though we store multipage into bvec. Signed-off-by: Ming Lei --- include/linux/bvec.h | 56 +++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 53 insertions(+), 3 deletions(-) diff --git a/include/linux/bvec.h b/include/linux/bvec.h index 89b65b82d98f..307a387eb29c 100644 --- a/include/linux/bvec.h +++ b/include/linux/bvec.h @@ -24,6 +24,42 @@ #include /* + * What is multipage bvecs(segment)? + * + * - bvec stored in bio->bi_io_vec is always multipage style vector + * + * - bvec(struct bio_vec) represents one physically contiguous I/O + * buffer, now the buffer may include more than one pages since + * multipage(mp) bvec is supported, and all these pages represented + * by one bvec is physically contiguous. Before mp support, at most + * one page can be included in one bvec, we call it singlepage(sp) + * bvec. + * + * - .bv_page of th bvec represents the 1st page in the mp segment + * + * - .bv_offset of the bvec represents offset of the buffer in the bvec + * + * The effect on the current drivers/filesystem/dm/bcache/...: + * + * - almost everyone supposes that one bvec only includes one single + * page, so we keep the sp interface not changed, for example, + * bio_for_each_segment() still returns bvec with single page + * + * - bio_for_each_segment_all() will be changed to return singlepage + * bvec too + * + * - during iterating, iterator variable(struct bvec_iter) is always + * updated in multipage bvec style and that means bvec_iter_advance() + * is kept not changed + * + * - returned(copied) singlepage bvec is generated in flight by bvec + * helpers from the stored mp bvec + * + * - In case that some components(such as iov_iter) need to support mp + * segment, we introduce new helpers(suffixed with _mp) for them. + */ + +/* * was unsigned short, but we might as well be ready for > 64kB I/O pages */ struct bio_vec { @@ -49,16 +85,30 @@ struct bvec_iter { */ #define __bvec_iter_bvec(bvec, iter) (&(bvec)[(iter).bi_idx]) -#define bvec_iter_page(bvec, iter) \ +#define bvec_iter_page_mp(bvec, iter) \ (__bvec_iter_bvec((bvec), (iter))->bv_page) -#define bvec_iter_len(bvec, iter) \ +#define bvec_iter_len_mp(bvec, iter) \ min((iter).bi_size, \ __bvec_iter_bvec((bvec), (iter))->bv_len - (iter).bi_bvec_done) -#define bvec_iter_offset(bvec, iter) \ +#define bvec_iter_offset_mp(bvec, iter) \ (__bvec_iter_bvec((bvec), (iter))->bv_offset + (iter).bi_bvec_done) +/* + * of singlepage(sp) segment. + * + * This helpers will be implemented for building sp bvec in flight. + */ +#define bvec_iter_offset_sp(bvec, iter) bvec_iter_offset_mp((bvec), (iter)) +#define bvec_iter_len_sp(bvec, iter) bvec_iter_len_mp((bvec), (iter)) +#define bvec_iter_page_sp(bvec, iter) bvec_iter_page_mp((bvec), (iter)) + +/* current interfaces support sp style at default */ +#define bvec_iter_page(bvec, iter) bvec_iter_page_sp((bvec), (iter)) +#define bvec_iter_len(bvec, iter) bvec_iter_len_sp((bvec), (iter)) +#define bvec_iter_offset(bvec, iter) bvec_iter_offset_sp((bvec), (iter)) + #define bvec_iter_bvec(bvec, iter) \ ((struct bio_vec) { \ .bv_page = bvec_iter_page((bvec), (iter)), \ -- 2.7.4