Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932942AbcL0QMB (ORCPT ); Tue, 27 Dec 2016 11:12:01 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35931 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933170AbcL0QLq (ORCPT ); Tue, 27 Dec 2016 11:11:46 -0500 Date: Tue, 27 Dec 2016 18:11:34 +0200 From: Krzysztof Kozlowski To: Jaehoon Chung Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com, kishon@ti.com, will.deacon@arm.com, catalin.marinas@arm.com, cpgs@samsung.com Subject: Re: [RFC PATCH 3/6] ARM64: dts: exynos5433: add the pcie_phy node for PCIe Message-ID: <20161227161134.ds67t5byucphwkjg@kozik-lap> References: <20161226052029.10552-1-jh80.chung@samsung.com> <20161226052029.10552-4-jh80.chung@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161226052029.10552-4-jh80.chung@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 52 On Mon, Dec 26, 2016 at 02:20:26PM +0900, Jaehoon Chung wrote: > To use the generic PHY framework, adds the pcie_phy node. > > Signed-off-by: Jaehoon Chung > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index 64226d5..2a15f18 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -805,6 +805,11 @@ > reg = <0x145f0000 0x1038>; > }; > > + syscon_fsys: syscon@156f0000 { > + compatible = "syscon"; > + reg = <0x156f0000 0x1044>; > + }; > + > gsc_0: video-scaler@13C00000 { > compatible = "samsung,exynos5433-gsc"; > reg = <0x13c00000 0x1000>; > @@ -1443,6 +1448,15 @@ > status = "disabled"; > }; > }; > + > + pcie_phy: pcie-phy@15680000 { > + #phy-cells = <0>; > + compatible = "samsung,exynos5433-pcie-phy"; Mostly we use the convention of compatible being first property. > + reg = <0x15680000 0x1000>; > + samsung,pmureg-phandle = <&pmu_system_controller>; > + samsung,fsys-sysreg = <&syscon_fsys>; > + status = "okay"; Why do you need to put status=okay here? Best regards, Krzysztof > + }; > }; > > timer: timer { > -- > 2.10.2 >