Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750804AbcL1DNf (ORCPT ); Tue, 27 Dec 2016 22:13:35 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:32978 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbcL1DNd (ORCPT ); Tue, 27 Dec 2016 22:13:33 -0500 MIME-Version: 1.0 In-Reply-To: <3335251.c58Y1Zf7PB@amdc3058> References: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com> <3335251.c58Y1Zf7PB@amdc3058> From: Pankaj Dubey Date: Wed, 28 Dec 2016 08:43:10 +0530 X-Google-Sender-Auth: g5ExZ1cW4N-OFwCzxOIoZ4mBqwg Message-ID: Subject: Re: [PATCH] PCI: exynos: refactor exynos pcie driver To: Bartlomiej Zolnierkiewicz Cc: "linux-arm-kernel@lists.infradead.org" , linux-kernel@vger.kernel.org, linux-samsung-soc , linux-pci@vger.kernel.org, Jingoo Han , Niyas Ahmed S T , Krzysztof Kozlowski , Jaehoon Chung , Kukjin Kim , Alim Akhtar , Bjorn Helgaas , sanath@samsung.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 49 Hi Bartlomiej, On 27 December 2016 at 19:05, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Friday, December 23, 2016 04:26:27 PM Pankaj Dubey wrote: >> From: Niyas Ahmed S T >> >> Currently Exynos PCIe driver is only supported for Exynos5440 SoC. >> This patch does refactoring of Exynos PCIe driver to extend support >> for other Exynos SoC. >> >> Following are the main changes done via this patch: >> 1) It adds separate structs for memory, clock resources. >> 2) It add exynos_pcie_ops struct which will allow us to support the >> differences in resources in different Exynos SoC. >> >> No functional change intended. >> >> Signed-off-by: Niyas Ahmed S T >> Signed-off-by: Pankaj Dubey > > I would also like to see the explanation for 1) (as already > requested by Jingoo). Otherwise it all looks fine to me: > > Reviewed-by: Bartlomiej Zolnierkiewicz > Thanks for review and Reviewed-by tag. In other thread as a reply to Jaehoon, I have explained reason behind point no 1, I hope this reason is sufficient to separate these resources from main exynos_pcie structs. Thanks, Pankaj Dubey > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html