Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750886AbcL1FlZ (ORCPT ); Wed, 28 Dec 2016 00:41:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33380 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbcL1FlV (ORCPT ); Wed, 28 Dec 2016 00:41:21 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 8FD84612D0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=vivek.gautam@codeaurora.org MIME-Version: 1.0 In-Reply-To: References: <1482253431-23160-1-git-send-email-vivek.gautam@codeaurora.org> <1482253431-23160-2-git-send-email-vivek.gautam@codeaurora.org> <20161222211633.ldk3ykqiat6peyw7@rob-hp-laptop> From: Vivek Gautam Date: Wed, 28 Dec 2016 11:10:02 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/4] dt-bindings: phy: Add support for QUSB2 phy To: Stephen Boyd Cc: Rob Herring , kishon , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Mark Rutland , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1857 Lines: 46 On Wed, Dec 28, 2016 at 6:43 AM, Stephen Boyd wrote: > On 12/22/2016 08:52 PM, Vivek Gautam wrote: >> >>>> + >>>> +Optional properties: >>>> + - nvmem-cells: a list of phandles to nvmem cells that contain fused >>>> + tuning parameters for qusb2 phy, one for each entry >>>> + in nvmem-cell-names. >>>> + - nvmem-cell-names: must be "tune2_hstx_trim" for cell containing >>>> + HS Tx trim value. >>> ditto. >> nvmem doesn't allow, at this point, to get the cells by index. >> Its APIs take 'const char' cell id and get the cell. >> >> We should add this support to get the cell by index. >> Will create a patch for that, and drop the '-names' property from bindings. >> > > If we introduce a cells based API just for this case of one phandle it > may make sense to allow the cell id to be NULL and default to whatever > cell is there without a names property. We do something similar with > clks where a NULL connection id defaults to the first phandle in the > list. Then we can avoid having a new set of DT specific APIs here. Of > course, documentation should be updated to indicate that a NULL cell_id > means use index 0 with DT. Right. This makes sense. I didn't notice that we do something similar in clocks. I will post a new change for this (which should be pretty small in comparison to earlier patchset that introduced new dt based APIs). > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project