Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750927AbcL1FtZ convert rfc822-to-8bit (ORCPT ); Wed, 28 Dec 2016 00:49:25 -0500 Received: from mga03.intel.com ([134.134.136.65]:49485 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbcL1FtX (ORCPT ); Wed, 28 Dec 2016 00:49:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,420,1477983600"; d="scan'208";a="1076904099" From: "Kweh, Hock Leong" To: David Miller , "f.fainelli@gmail.com" CC: "Joao.Pinto@synopsys.com" , "peppe.cavallaro@st.com" , "seraphin.bonnaffe@st.com" , "alexandre.torgue@gmail.com" , "manabian@gmail.com" , "niklas.cassel@axis.com" , "johan@kernel.org" , "pavel@ucw.cz" , "Ong, Boon Leong" , "Voon, Weifeng" , "lars.persson@axis.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe Thread-Topic: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe Thread-Index: AQHSYAv4FCVbYJ2YS0yP58zd4NjMrqEbd9+AgAFVaIA= Date: Wed, 28 Dec 2016 05:49:18 +0000 Message-ID: References: <1482849756-21817-1-git-send-email-hock.leong.kweh@intel.com> <20161227.113405.362102687632949941.davem@davemloft.net> In-Reply-To: <20161227.113405.362102687632949941.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1665 Lines: 56 > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Wednesday, December 28, 2016 12:34 AM > To: Kweh, Hock Leong > Cc: Joao.Pinto@synopsys.com; peppe.cavallaro@st.com; > seraphin.bonnaffe@st.com; f.fainelli@gmail.com; > alexandre.torgue@gmail.com; manabian@gmail.com; niklas.cassel@axis.com; > johan@kernel.org; pavel@ucw.cz; Ong, Boon Leong > ; Voon, Weifeng ; > lars.persson@axis.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and > stmmac_dvr_probe > > From: "Kweh, Hock Leong" > Date: Tue, 27 Dec 2016 22:42:36 +0800 > > > From: "Kweh, Hock Leong" > > You are not the author of this change, do not take credit for it. > > You have copied Florian's patch character by character, therefore > he is the author. > > You also didn't CC: the netdev mailing list properly. Hi David & Florian, Just to clarify that I do not copy exactly from Florian. I have changed it to have proper handling on mdio unregister while netdev_register() failed as showed below: return 0; -error_mdio_register: - unregister_netdev(ndev); error_netdev_register: + stmmac_mdio_unregister(ndev); +error_mdio_register: netif_napi_del(&priv->napi); Vs + + return ret; error_mdio_register: - unregister_netdev(ndev); -error_netdev_register: netif_napi_del(&priv->napi); Just to point it out here, so that Florian could aware if he/she submit this fix to the mailing list. Thanks & Regards, Wilson