Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751571AbcL1MlP (ORCPT ); Wed, 28 Dec 2016 07:41:15 -0500 Received: from mail-qt0-f182.google.com ([209.85.216.182]:35049 "EHLO mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbcL1MlN (ORCPT ); Wed, 28 Dec 2016 07:41:13 -0500 MIME-Version: 1.0 In-Reply-To: <20161206140817.11708-1-narmstrong@baylibre.com> References: <20161206140817.11708-1-narmstrong@baylibre.com> From: Linus Walleij Date: Wed, 28 Dec 2016 13:41:12 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes To: Neil Armstrong Cc: Carlo Caione , Kevin Hilman , "linux-gpio@vger.kernel.org" , "open list:ARM/Amlogic Meson..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Beniamino Galvani Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 599 Lines: 15 On Tue, Dec 6, 2016 at 3:08 PM, Neil Armstrong wrote: > The pinctrl_gpio_request is called with the "full" gpio number, already > containing the base, then meson_pmx_request_gpio is then called with the > final pin number. > Remove the base addition when calling meson_pmx_disable_other_groups. > > Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") > CC: Beniamino Galvani > Signed-off-by: Neil Armstrong Patch applied for fixes. Sorry for the delay, merge window appeared inbetween. Yours, Linus Walleij