Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751727AbcL1POW (ORCPT ); Wed, 28 Dec 2016 10:14:22 -0500 Received: from mx2.suse.de ([195.135.220.15]:32840 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751655AbcL1POV (ORCPT ); Wed, 28 Dec 2016 10:14:21 -0500 Date: Wed, 28 Dec 2016 16:14:19 +0100 Message-ID: From: Takashi Iwai To: "Gabriele Mazzotta" Cc: , , Subject: Re: [PATCH 1/2] ALSA: hda - Apply ALC269_FIXUP_NO_SHUTUP on HDA_FIXUP_ACT_PROBE In-Reply-To: <20161224185001.26824-1-gabriele.mzt@gmail.com> References: <20161224185001.26824-1-gabriele.mzt@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1097 Lines: 36 On Sat, 24 Dec 2016 19:50:00 +0100, Gabriele Mazzotta wrote: > > Setting shutup when the action is HDA_FIXUP_ACT_PRE_PROBE might > not have the desired effect since it could be overridden by > another more generic shutup function. Prevent this by setting > the more specific shutup function on HDA_FIXUP_ACT_PROBE. > > Signed-off-by: Gabriele Mazzotta Applied both patches now. Thanks. Takashi > --- > sound/pci/hda/patch_realtek.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index ea81c08ddc7a..d30cc49512e4 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -4400,7 +4400,7 @@ static void alc_no_shutup(struct hda_codec *codec) > static void alc_fixup_no_shutup(struct hda_codec *codec, > const struct hda_fixup *fix, int action) > { > - if (action == HDA_FIXUP_ACT_PRE_PROBE) { > + if (action == HDA_FIXUP_ACT_PROBE) { > struct alc_spec *spec = codec->spec; > spec->shutup = alc_no_shutup; > } > -- > 2.11.0 > >