MIME-Version: 1.0
In-Reply-To: <874m1p3a3v.fsf@linux.intel.com>
References: <0d79eb1f34e409749a136173b68f365b545c4789.1482738764.git.baolin.wang@linaro.org>
 <5861D477.7070407@linux.intel.com> <874m1p3a3v.fsf@linux.intel.com>
From: Janusz Dziedzic <janusz.dziedzic@gmail.com>
Date: Wed, 28 Dec 2016 16:27:42 +0100
Message-ID: <CAFED-j=CUdGNtt0CsZPDZNMn9Op3tmAneNqscQRyFneibAOOjQ@mail.gmail.com>
Subject: Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt
 handler and irq thread handler
To: Felipe Balbi <balbi@kernel.org>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
        Baolin Wang <baolin.wang@linaro.org>,
        Greg KH <gregkh@linuxfoundation.org>, USB <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
        Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1063
Lines: 34

2016-12-27 12:05 GMT+01:00 Felipe Balbi <balbi@kernel.org>:
> Hi,
>
> Lu Baolu <baolu.lu@linux.intel.com> writes:
>> On 12/26/2016 04:01 PM, Baolin Wang wrote:
>>> On some platfroms(like x86 platform), when one core is running the USB gadget
>>> irq thread handler by dwc3_thread_interrupt(), meanwhile another core also can
>>> respond other interrupts from dwc3 controller and modify the event buffer by
>>> dwc3_interrupt() function, that will cause getting the wrong event count in
>>> irq thread handler to make the USB function abnormal.
>>>
>>> We should add spin_lock/unlock() in dwc3_check_event_buf() to avoid this race.
>>
>> Why not spin_lock_irq ones? This lock seems to be used in both
>> normal and interrupt threads. Or, I missed anything?
>
> this is top half handler. Interrupts are already disabled.
>
BTW,
We don't use spin_lock in top half handler.
Maybe we should/can switch all spin_lock_irqsave() to simple
spin_lock() in the thread/callbacks?
Or there is a reason to use irqsave() version?

BR
Janusz

> --
> balbi


-- 
Janusz Dziedzic