Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751493AbcL1Qbn (ORCPT ); Wed, 28 Dec 2016 11:31:43 -0500 Received: from mga05.intel.com ([192.55.52.43]:64461 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbcL1Qbl (ORCPT ); Wed, 28 Dec 2016 11:31:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,422,1477983600"; d="scan'208";a="1077053457" Message-ID: <1482942696.9552.172.camel@linux.intel.com> Subject: Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module From: Andy Shevchenko To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com Date: Wed, 28 Dec 2016 18:31:36 +0200 In-Reply-To: <20e47113-efd7-787c-b2f8-39e9fd8b83d2@synopsys.com> References: <1482939844.9552.165.camel@linux.intel.com> <20e47113-efd7-787c-b2f8-39e9fd8b83d2@synopsys.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 47 On Wed, 2016-12-28 at 15:53 +0000, Luis Oliveira wrote: > On 28-Dec-16 15:44, Andy Shevchenko wrote: > > On Wed, 2016-12-28 at 14:43 +0000, Luis Oliveira wrote: > > > - Slave mode selected in platform module (devicetree support only) > > > - Check for ACPI - not supported in SLAVE mode: > > >   - Changed the ifndef style to the use of ACPI_HANDLE that > > > returns > > > NULL > > >     if the device was not enumerated from ACPI namespace. > > > > I'm not sure what is wrong with ACPI? > > I dont have a way to test it. Just that. Okay, can you provide an excerpt to see how it will look like in DTS?   > > > - dev->functionality = I2C_FUNC_10BIT_ADDR | > > > DW_IC_DEFAULT_FUNCTIONALITY; > > > - > > > - i2c_dw_configure_master(pdev); > > > + if (ACPI_HANDLE(&pdev->dev) == NULL) { > > > > I don't think you need this at all. > > This is to avoid the use of the "ifdef" style I used before. My point is to drop it completely. > > > > > + device_for_each_child_node(&pdev->dev, child) { > > > > This is resource agnostic. > > > > > + fwnode_property_read_u32(child, "reg", > > > ®); > > > > This is as well. > > Are you suggesting I use of_ functions? Nope. See above. -- Andy Shevchenko Intel Finland Oy