Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752056AbcL1Qt6 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 28 Dec 2016 11:49:58 -0500
Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:50676 "EHLO
        smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751739AbcL1Qt4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Dec 2016 11:49:56 -0500
Subject: Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module
To: Luis Oliveira <Luis.Oliveira@synopsys.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Luis Oliveira <Luis.Oliveira@synopsys.com>, <wsa@the-dreams.de>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <jarkko.nikula@linux.intel.com>, <mika.westerberg@linux.intel.com>,
        <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <cover.1482934380.git.lolivei@synopsys.com>
 <ea8b611c3b7c2af8088e2dbc16554af5c8aed368.1482934380.git.lolivei@synopsys.com>
 <1482939844.9552.165.camel@linux.intel.com>
 <20e47113-efd7-787c-b2f8-39e9fd8b83d2@synopsys.com>
 <1482942696.9552.172.camel@linux.intel.com>
 <c41db9e0-756d-6697-a845-0d5b1efcaedc@synopsys.com>
CC: <Ramiro.Oliveira@synopsys.com>, <Joao.Pinto@synopsys.com>,
        <CARLOS.PALMINHA@synopsys.com>
From: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Message-ID: <1859a4e9-b10f-4f0e-1ea7-660dea6bb7be@synopsys.com>
Date: Wed, 28 Dec 2016 16:49:50 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <c41db9e0-756d-6697-a845-0d5b1efcaedc@synopsys.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.107.25.78]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1761
Lines: 68



On 28-12-2016 16:41, Luis Oliveira wrote:
> On 28-Dec-16 16:31, Andy Shevchenko wrote:
>> On Wed, 2016-12-28 at 15:53 +0000, Luis Oliveira wrote:
>>> On 28-Dec-16 15:44, Andy Shevchenko wrote:
>>>> On Wed, 2016-12-28 at 14:43 +0000, Luis Oliveira wrote:
>>>>> - Slave mode selected in platform module (devicetree support only)
>>>>> - Check for ACPI - not supported in SLAVE mode:
>>>>>   - Changed the ifndef style to the use of ACPI_HANDLE that
>>>>> returns
>>>>> NULL
>>>>>     if the device was not enumerated from ACPI namespace.
>>>>
>>>> I'm not sure what is wrong with ACPI?
>>>
>>> I dont have a way to test it. Just that.
>>
>> Okay, can you provide an excerpt to see how it will look like in DTS?
> 
> Yes, it looks like this now:
> 
> 	i2c@0x2000 {
> 			compatible = "snps,designware-i2c";
> 			#address-cells = <1>;
> 			#size-cells = <0>;
> 			reg = <0x2000 0x100>;
> 			clock-frequency = <400000>;
> 			clocks = <&i2cclk>;
> 			interrupts = <0>;
> 
> 			eeprom@64 {
> 				compatible = "linux,slave-24c02";
> 				reg = <0x40000064>;
> 			};
> 	};

Probably this can be included as example in the device tree binding document.

>>  
>>>>> -	dev->functionality = I2C_FUNC_10BIT_ADDR |
>>>>> DW_IC_DEFAULT_FUNCTIONALITY;
>>>>> -
>>>>> -	i2c_dw_configure_master(pdev);
>>>>> +	if (ACPI_HANDLE(&pdev->dev) == NULL) {
>>>>
>>>> I don't think you need this at all.
>>>
>>> This is to avoid the use of the "ifdef" style I used before.
>>
>> My point is to drop it completely.
>>
>>>>
>>>>> +		device_for_each_child_node(&pdev->dev, child) {
>>>>
>>>> This is resource agnostic.
>>>>
>>>>> +			fwnode_property_read_u32(child, "reg",
>>>>> &reg);
>>>>
>>>> This is as well.
>>>
>>> Are you suggesting I use of_ functions?
>>
>> Nope. See above.
>>
>>
>