Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbcL1XET (ORCPT ); Wed, 28 Dec 2016 18:04:19 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52310 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752177AbcL1XEQ (ORCPT ); Wed, 28 Dec 2016 18:04:16 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org F119461632 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 28 Dec 2016 15:04:12 -0800 From: Stephen Boyd To: Vivek Gautam Cc: robh+dt@kernel.org, kishon@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mark.rutland@arm.com, srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3 3/4] dt-bindings: phy: Add support for QMP phy Message-ID: <20161228230412.GC17126@codeaurora.org> References: <1482253431-23160-1-git-send-email-vivek.gautam@codeaurora.org> <1482253431-23160-4-git-send-email-vivek.gautam@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482253431-23160-4-git-send-email-vivek.gautam@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 30 On 12/20, Vivek Gautam wrote: > + > +Example: > + pcie_phy: phy@34000 { > + compatible = "qcom,msm8996-qmp-pcie-phy"; > + reg = <0x034000 0x48f>, > + <0x035000 0x5bf>, > + <0x036000 0x5bf>, > + <0x037000 0x5bf>; > + /* tx, rx, pcs */ > + lane-offsets = <0x0 0x200 0x400>; > + #phy-cells = <1>; > + > + clocks = <&gcc GCC_PCIE_PHY_AUX_CLK>, > + <&gcc GCC_PCIE_PHY_CFG_AHB_CLK>, > + <&gcc GCC_PCIE_CLKREF_CLK>, > + <&gcc GCC_PCIE_0_PIPE_CLK>, > + <&gcc GCC_PCIE_1_PIPE_CLK>, > + <&gcc GCC_PCIE_2_PIPE_CLK>; > + clock-names = "aux", "cfg_ahb", "ref", > + "pipe0", "pipe1", "pipe2"; Can we add a #clock-cells = <0> or <1> here given that this is a clk provider? We may want to express the clk circular dependency between this phy node and GCC via the clocks property at some point instead of doing it implicitly via strings in C code. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project