Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751817AbcL2FFQ (ORCPT ); Thu, 29 Dec 2016 00:05:16 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:49260 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbcL2FFO (ORCPT ); Thu, 29 Dec 2016 00:05:14 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 84CDB61371 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=vivek.gautam@codeaurora.org MIME-Version: 1.0 In-Reply-To: <20161228230412.GC17126@codeaurora.org> References: <1482253431-23160-1-git-send-email-vivek.gautam@codeaurora.org> <1482253431-23160-4-git-send-email-vivek.gautam@codeaurora.org> <20161228230412.GC17126@codeaurora.org> From: Vivek Gautam Date: Thu, 29 Dec 2016 10:35:11 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/4] dt-bindings: phy: Add support for QMP phy To: Stephen Boyd Cc: "robh+dt" , kishon , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Mark Rutland , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1643 Lines: 41 On Thu, Dec 29, 2016 at 4:34 AM, Stephen Boyd wrote: > On 12/20, Vivek Gautam wrote: >> + >> +Example: >> + pcie_phy: phy@34000 { >> + compatible = "qcom,msm8996-qmp-pcie-phy"; >> + reg = <0x034000 0x48f>, >> + <0x035000 0x5bf>, >> + <0x036000 0x5bf>, >> + <0x037000 0x5bf>; >> + /* tx, rx, pcs */ >> + lane-offsets = <0x0 0x200 0x400>; >> + #phy-cells = <1>; >> + >> + clocks = <&gcc GCC_PCIE_PHY_AUX_CLK>, >> + <&gcc GCC_PCIE_PHY_CFG_AHB_CLK>, >> + <&gcc GCC_PCIE_CLKREF_CLK>, >> + <&gcc GCC_PCIE_0_PIPE_CLK>, >> + <&gcc GCC_PCIE_1_PIPE_CLK>, >> + <&gcc GCC_PCIE_2_PIPE_CLK>; >> + clock-names = "aux", "cfg_ahb", "ref", >> + "pipe0", "pipe1", "pipe2"; > > Can we add a #clock-cells = <0> or <1> here given that this is a > clk provider? We may want to express the clk circular dependency > between this phy node and GCC via the clocks property at some > point instead of doing it implicitly via strings in C code. Sure, will add #clock-cells = <1>. Although phys like USB and PIPE currently have just the pipe_clk being controlled by gcc, the UFS phy has tx/rx symbol clocks that are controlled by gcc but are generated by phy the same way as pipe_clk. So, i guess #clock-cells = <1 > makes sense. Thanks Vivek -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project