Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbcL2Fxh (ORCPT ); Thu, 29 Dec 2016 00:53:37 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:55699 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbcL2Fxg (ORCPT ); Thu, 29 Dec 2016 00:53:36 -0500 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.249.25 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 29 Dec 2016 14:53:29 +0900 From: Minchan Kim To: Michal Hocko CC: , Andrew Morton , Mel Gorman , Johannes Weiner , Vlastimil Babka , Rik van Riel , LKML , Michal Hocko Subject: Re: [PATCH 3/7] mm, vmscan: show the number of skipped pages in mm_vmscan_lru_isolate Message-ID: <20161229055329.GB1815@bbox> References: <20161228153032.10821-1-mhocko@kernel.org> <20161228153032.10821-4-mhocko@kernel.org> MIME-Version: 1.0 In-Reply-To: <20161228153032.10821-4-mhocko@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/12/29 14:53:31, Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/12/29 14:53:31, Serialize complete at 2016/12/29 14:53:31 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 13 On Wed, Dec 28, 2016 at 04:30:28PM +0100, Michal Hocko wrote: > From: Michal Hocko > > mm_vmscan_lru_isolate shows the number of requested, scanned and taken > pages. This is mostly OK but on 32b systems the number of scanned pages > is quite misleading because it includes both the scanned and skipped > pages. Moreover the skipped part is scaled based on the number of taken > pages. Let's report the exact numbers without any additional logic and > add the number of skipped pages. This should make the reported data much > more easier to interpret. > > Signed-off-by: Michal Hocko Acked-by: Minchan Kim