Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752263AbcL2Gv7 (ORCPT ); Thu, 29 Dec 2016 01:51:59 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33438 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbcL2Gv5 (ORCPT ); Thu, 29 Dec 2016 01:51:57 -0500 Date: Thu, 29 Dec 2016 15:52:05 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Xishi Qiu , ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, Linux MM , LKML Subject: Re: mm: fix typo of cache_alloc_zspage() Message-ID: <20161229065205.GA3892@jagdpanzerIV.localdomain> References: <58646FB7.2040502@huawei.com> <20161229064457.GD1815@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161229064457.GD1815@bbox> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 25 On (12/29/16 15:44), Minchan Kim wrote: > On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote: > > Signed-off-by: Xishi Qiu > > --- > > mm/zsmalloc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > > index 9cc3c0b..2d6c92e 100644 > > --- a/mm/zsmalloc.c > > +++ b/mm/zsmalloc.c > > @@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags) > > { > > return kmem_cache_alloc(pool->zspage_cachep, > > flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE)); > > -}; > > +} > > Although it's trivial, we need descritpion. > Please, could you resend to Andrew Morton with filling description? I don't know... do we want to have it as a separate patch? may be we can fold it into some other patch someday later. -ss